Re: A fix for pmccabe2html

2010-09-21 Thread Simon Josefsson
Reuben Thomas writes: > On 20 September 2010 15:49, Eric Blake wrote: >> Rather than describing the fix, could you post this as a patch? > > Sorry; you've made me realise that my habit of not posting patches for > code I'm not sure about is silly for several reasons. > > Patch attached. I've add

Re: A fix for pmccabe2html

2010-09-20 Thread Reuben Thomas
On 20 September 2010 15:49, Eric Blake wrote: > Rather than describing the fix, could you post this as a patch? Sorry; you've made me realise that my habit of not posting patches for code I'm not sure about is silly for several reasons. Patch attached. I've added an Emacs mode-setting line to th

Re: A fix for pmccabe2html

2010-09-20 Thread Eric Blake
On 09/19/2010 04:54 PM, Reuben Thomas wrote: After investigation, I think I found the bug: cut_dir should not be hardwired to "/../", but rather set to "${top_srcdir}/". Otherwise, it does not work for a typical in-tree build: cut_dir is not found in the path, index returns 0, and an arbitrary fe

A fix for pmccabe2html

2010-09-19 Thread Reuben Thomas
After investigation, I think I found the bug: cut_dir should not be hardwired to "/../", but rather set to "${top_srcdir}/". Otherwise, it does not work for a typical in-tree build: cut_dir is not found in the path, index returns 0, and an arbitrary few characters are cut off the front of each file