Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-13 Thread Bruno Haible
Simon Josefsson wrote: > Alas, GNULIB_REVISION is not documented in doc/gnulib.texi. Yes, that's because the more modern way is to use a git submodule instead. This is documented in https://www.gnu.org/software/gnulib/manual/html_node/VCS-Issues.html https://www.gnu.org/software/gnulib/manual/html

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-13 Thread Bruno Haible
Hi Simon, > Bug #2: ./bootstrap writes to the path indicated by --gnulib-srcdir with > the 'git checkout' command, and leaves the --gnulib-srcdir path at that > commit after ./bootstrap is finished. This happens to work in my > example since I pointed it to a writable work tree, but I think alter

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-13 Thread Bruno Haible
Hi Simon, After fixing the --help output, I'm changing the 'bootstrap' logic to follow this documentation. Two patches: * 0001 simplifies the logic by removing fallback code for git versions < 1.6.4. Version 1.6.4 was released in 2009, that is, 15 years ago. When encountering such an old versi

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-13 Thread Bruno Haible
Simon Josefsson wrote: > My reaction was initially exactly the same as yours, until I found this > piece of --help documentation, which actually is the first (and > presumably highest priority) rule: > > * If the environment variable GNULIB_SRCDIR is set (either as an >environment variable or

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-10 Thread Simon Josefsson via Gnulib discussion list
Simon Josefsson via Gnulib discussion list writes: > My reaction was initially exactly the same as yours, until I found this > piece of --help documentation, which actually is the first (and > presumably highest priority) rule: > > * If the environment variable GNULIB_SRCDIR is set (either as an

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-10 Thread Simon Josefsson via Gnulib discussion list
Bruno Haible writes: > Hi Simon, > >> Bug #2: ./bootstrap writes to the path indicated by --gnulib-srcdir with >> the 'git checkout' command, and leaves the --gnulib-srcdir path at that >> commit after ./bootstrap is finished. This happens to work in my >> example since I pointed it to a writabl

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-10 Thread Bruno Haible
Hi Simon, > Bug #2: ./bootstrap writes to the path indicated by --gnulib-srcdir with > the 'git checkout' command, and leaves the --gnulib-srcdir path at that > commit after ./bootstrap is finished. This happens to work in my > example since I pointed it to a writable work tree, but I think alter

Re: ./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-10 Thread Paul Eggert
My quick reaction is that you've identified two bugs. --gnulib-srcdir should only read from that directory, and GNULIB_REVISION should work in bootstrap.conf.

./bootstrap --gnulib-srcdir and GNULIB_REVISION

2024-04-10 Thread Simon Josefsson via Gnulib discussion list
Hi I'm trying to get ./bootstrap from a minimal source-only archive generated via 'git archive' that has GNULIB_REVISION set in bootstrap.conf, expecting this to work: ./bootstrap --gnulib-srcdir=/home/jas/src/gnulib Bug #1: it seems GNULIB_REVISION in bootstrap.conf has no effect, and this code