Re: [bug-gnulib] new module 'sigprocmask'

2006-10-17 Thread Bruno Haible
Eric Blake wrote: > Checking in this obvious patch: > > 2006-10-17 Eric Blake <[EMAIL PROTECTED]> > > * lib/sigprocmask.c (sigprocmask): Fix typo. > Thanks for turning untested into tested code! (I usually only cross-compile to mingw, without testing.) Bruno

Re: [bug-gnulib] new module 'sigprocmask'

2006-10-16 Thread Bruno Haible
Eric Blake wrote: > I'm getting failures on mingw: > > In file included from ../../lib/fatal-signal.c:30: > ../../lib/sigprocmask.h:34: error: conflicting types for 'sigset_t' > /usr/lib/gcc/i686-pc-mingw32/3.4.4/../../../../i686-pc- > mingw32/include/sys/types.h:95: error: previous declaration of

Re: [bug-gnulib] new module 'sigprocmask'

2006-10-16 Thread Bruno Haible
Paul Eggert wrote: > > + /* Set of currently blocked and pending signals. */ > > + static volatile char pending_array[NSIG] /* = { 0 } */; > > Surely this should be sig_atomic_t rather than char? > > > + int > > + sigfillset (sigset_t *set) > > + { > > + *set = -2U << (NSIG - 1); > > This doe