Re: [bug-gnulib] Proposed Module: canonicalize-lgpl

2006-11-06 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > Additionally, can we please add a comment here? Sure. For consistency there should be a comment for canonicalize_filename_mode so I installed the following patch for canonicalize.h along with the other patches already mentioned. Another consistency cha

Re: [bug-gnulib] Proposed Module: canonicalize-lgpl

2006-11-06 Thread Bruno Haible
Paul Eggert wrote: > I guess the basic idea here is that we move this module from gettext > to gnulib Yes, this is the idea. > Here is a slightly different proposal to add that module; it assumes > the 'canonicalize' changes I just installed. What do you think? Looks fine. I too like the idea o

Re: [bug-gnulib] Proposed Module: canonicalize-lgpl

2006-11-03 Thread Bruno Haible
Paul Eggert wrote: > I'd prefer something more like fts, where > the code itself is the same in both modules ... > Can't we slim it down to one copy? Hmm, in terms of maintainability, borrowing an implementation from glibc doesn't cost much, since the code in glibc doesn't change often. Either wa