Re: [V2 PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-28 Thread Jia Zhang
于 2017/10/28 下午9:09, Bruno Haible 写道: > Jia Zhang wrote: >>> gcc: error: @LIB_CRYPTO@: No such file or directory >> >> Thanks for your comments. I fixed it and the test passes. I just >> feel strange that test-sm3 was built out without error if I >> compiled gnulib with coreutils together. > >

Re: [V2 PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-28 Thread Bruno Haible
Jia Zhang wrote: > > gcc: error: @LIB_CRYPTO@: No such file or directory > > Thanks for your comments. I fixed it and the test passes. I just feel > strange that test-sm3 was built out without error if I compiled gnulib > with coreutils together. It passed with coreutils because coreutils request

Re: [V2 PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-28 Thread Jia Zhang
于 2017/10/28 下午8:44, Bruno Haible 写道: > [Dropping coreutils, since I'm replying only the gnulib part.] > > Hi Jia, > >> Plz refer to the following PRs for code review. >> >> - For the new gnulib module crypto/sm3 >> https://github.com/coreutils/gnulib/pull/3/commits > > Usually, on this mail

Re: [V2 PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-28 Thread Bruno Haible
[Dropping coreutils, since I'm replying only the gnulib part.] Hi Jia, > Plz refer to the following PRs for code review. > > - For the new gnulib module crypto/sm3 > https://github.com/coreutils/gnulib/pull/3/commits Usually, on this mailing list, we share patches through 'git format-patch -1

[V2 PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-28 Thread Jia Zhang
Hi Pádraig & Bruno, This is the V2 review request for SM3 hash algorithm. As promised, I have made SM3 hash algorithm available in the latest libgcrypt. See https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=4423bf3cc4432b9bfe801ff74cb05e6f0dd3eccd The V2 patch adds the support