Re: [PATCHv2 5/4] nonblocking: reduce dependency

2011-04-19 Thread Bruno Haible
Eric Blake wrote: > > From b7d23617875e1498f3b3ea8c6e6e31d6d9195bf9 Mon Sep 17 00:00:00 2001 > > From: Bruno Haible > > Date: Mon, 18 Apr 2011 02:34:47 +0200 > > Subject: [PATCH] Generalize close-hook to fd-hook. > > Looks nice. Thanks. I committed it after some more testing and cleanups. > Git

Re: [PATCHv2 5/4] nonblocking: reduce dependency

2011-04-18 Thread Eric Blake
On 04/17/2011 06:35 PM, Bruno Haible wrote: >> >> +nonblocking: reduce dependency >> +* tests/test-nonblocking.c: Only test sockets when in use. > > The intention was good. But this patch does not work for two reasons: > > 1) The preprocessor macro GNULIB_SOCKET is nowhere defined. Theref

Re: [PATCHv2 5/4] nonblocking: reduce dependency

2011-04-17 Thread Bruno Haible
Hi Eric, > 2011-04-08 Eric Blake > > + nonblocking: reduce dependency > + * tests/test-nonblocking.c: Only test sockets when in use. > + * modules/nonblocking-tests (Depends-on): Drop socket. > + (Makefile.am): Link even if sockets are not present. > + * modules/pipe2-test

[PATCHv2 5/4] nonblocking: reduce dependency

2011-04-08 Thread Eric Blake
No need to make nonblocking drag in sockets just for a test; test them if they are present and skip them otherwise. * tests/test-nonblocking.c: Only test sockets when in use. * modules/nonblocking-tests (Depends-on): Drop socket. (Makefile.am): Link even if sockets are not present. * modules/pipe2