Re: [PATCH v7 11/11] gnulib-tool: fall back into copy if symbolic link is not supported

2017-06-08 Thread Myung-Hun KO
Thanks! 2017. 6. 8. 오후 9:46에 "Bruno Haible" 님이 작성: Paul Eggert wrote on 2016-01-15: > Thanks, I installed the attached somewhat-different patch instead. > Please give it a try. This func_ln_s has a bug: when both arguments are relative and the second one is in the current directory, the copy sou

Re: [PATCH v7 11/11] gnulib-tool: fall back into copy if symbolic link is not supported

2017-06-08 Thread Bruno Haible
Paul Eggert wrote on 2016-01-15: > Thanks, I installed the attached somewhat-different patch instead. > Please give it a try. This func_ln_s has a bug: when both arguments are relative and the second one is in the current directory, the copy source will be wrong. I.e. func_ln_s a/b y will ess

Re: [PATCH v7 11/11] gnulib-tool: fall back into copy if symbolic link is not supported

2016-01-24 Thread KO Myung-Hun
Paul Eggert wrote: > KO Myung-Hun wrote: >> But, you said that it was enough to warn only once. > > True, and the current implementation doesn't have that nicety. However, > it's not essential to support it, and not all that important as > gnulib-tool will be run only rarely on file systems lack

Re: [PATCH v7 11/11] gnulib-tool: fall back into copy if symbolic link is not supported

2016-01-24 Thread Paul Eggert
KO Myung-Hun wrote: But, you said that it was enough to warn only once. True, and the current implementation doesn't have that nicety. However, it's not essential to support it, and not all that important as gnulib-tool will be run only rarely on file systems lacking symlinks.

Re: [PATCH v7 11/11] gnulib-tool: fall back into copy if symbolic link is not supported

2016-01-24 Thread KO Myung-Hun
Paul Eggert wrote: > KO Myung-Hun wrote: >> Some time ago, you reviewed my patch, and advised to do so because 'ln >> -s' may succeed on some file systems, or may fail on another file >> systems. > > Thanks for reminding me; I had forgotten about that consideration. I > installed the attached pa

Re: [PATCH v7 11/11] gnulib-tool: fall back into copy if symbolic link is not supported

2016-01-24 Thread Paul Eggert
KO Myung-Hun wrote: Some time ago, you reviewed my patch, and advised to do so because 'ln -s' may succeed on some file systems, or may fail on another file systems. Thanks for reminding me; I had forgotten about that consideration. I installed the attached patch to fix this. >From eda1f5cae

Re: [PATCH v7 11/11] gnulib-tool: fall back into copy if symbolic link is not supported

2016-01-15 Thread KO Myung-Hun
Hi/2. Paul Eggert wrote: > Thanks, I installed the attached somewhat-different patch instead. > Please give it a try. Works here. But it is different from my patch. My patch calls 'ln -s' every time. And if it fails, fallback to 'cp -p'. However, the installed patch seems to call 'ln -s'. If it

Re: [PATCH v7 11/11] gnulib-tool: fall back into copy if symbolic link is not supported

2016-01-15 Thread Paul Eggert
Thanks, I installed the attached somewhat-different patch instead. Please give it a try. Also, I installed the other two gnulib patches pretty much as-is. diff --git a/ChangeLog b/ChangeLog index 5bedafa..80d496e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2016-01-15 Paul Eggert +

Re: [PATCH v7 11/11] gnulib-tool: fall back into copy if symbolic link is not supported

2016-01-14 Thread KO Myung-Hun
Paul Eggert wrote: > On 01/13/2016 06:23 PM, KO Myung-Hun wrote: >> + *) # SRC is relative to the directory of DEST. >> +cp_src="`echo "$2" | sed -e 's,\(^.*\)/[^/]*$,\1,'`/$1" ;; > > Can we use parameter expansion instead? Something like this, say: > > cp_src=${2%/*}/$1 Updated.

Re: [PATCH v7 11/11] gnulib-tool: fall back into copy if symbolic link is not supported

2016-01-14 Thread Paul Eggert
On 01/13/2016 06:23 PM, KO Myung-Hun wrote: + *) # SRC is relative to the directory of DEST. +cp_src="`echo "$2" | sed -e 's,\(^.*\)/[^/]*$,\1,'`/$1" ;; Can we use parameter expansion instead? Something like this, say: cp_src=${2%/*}/$1

[PATCH v7 11/11] gnulib-tool: fall back into copy if symbolic link is not supported

2016-01-13 Thread KO Myung-Hun
And warn about it only once. * gnulib-tool (first_fall_back_to_cp_warn): New. Indicator for only once warning about falling back to cp -p. (func_ln_s): New. Fall back into cp -p if ln -s fails. And warn about this only once. (func_ln): Replace ln -s with func_ln_s. --- gnulib-tool | 35 ++