Re: [PATCH v2 1/2] posix: Add compat glob symbol to not follow dangling symbols

2017-09-27 Thread Andreas Schwab
I can confirm that make works properly with the compat glob symbol. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH v2 1/2] posix: Add compat glob symbol to not follow dangling symbols

2017-09-26 Thread Adhemerval Zanella
On 26/09/2017 11:10, Paul Eggert wrote: > On 09/26/2017 10:24 AM, Adhemerval Zanella wrote: >> I see other possible issues that would >> need to be fixed as well: >> >>    * FLEXIBLE_ARRAY_MEMBER definition for !__LIBC. >>    * __glob_pattern_type duplicated prototype. >>    * __set_errno and memp

Re: [PATCH v2 1/2] posix: Add compat glob symbol to not follow dangling symbols

2017-09-26 Thread Paul Eggert
On 09/26/2017 10:24 AM, Adhemerval Zanella wrote: I see other possible issues that would need to be fixed as well: * FLEXIBLE_ARRAY_MEMBER definition for !__LIBC. * __glob_pattern_type duplicated prototype. * __set_errno and mempcpy definition. Thanks for reporting the duplicated prot

Re: [PATCH v2 1/2] posix: Add compat glob symbol to not follow dangling symbols

2017-09-26 Thread Adhemerval Zanella
On 26/09/2017 08:29, Andreas Schwab wrote: > Current version of make won't build against this (undefined reference to > __alloca from included glob sources). > > Andreas. > I am not very familiar of the process to incorporate gnulib code in external projects, but I see other possible issues that wo

Re: [PATCH v2 1/2] posix: Add compat glob symbol to not follow dangling symbols

2017-09-26 Thread Andreas Schwab
Current version of make won't build against this (undefined reference to __alloca from included glob sources). Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH v2 1/2] posix: Add compat glob symbol to not follow dangling symbols

2017-09-25 Thread Adhemerval Zanella
On 22/09/2017 18:43, Paul Eggert wrote: > On 09/22/2017 06:02 AM, Adhemerval Zanella wrote: >> +   ((flags & (GLOB_ERR | GLOB_NOESCAPE | GLOB_ALTDIRFUNC)) >> +   | GLOB_NOSORT | GLOB_ONLYDIR), > > The indenting is not quite right here: the "|" should be under the 2nd > "(" i

Re: [PATCH v2 1/2] posix: Add compat glob symbol to not follow dangling symbols

2017-09-22 Thread Paul Eggert
On 09/22/2017 06:02 AM, Adhemerval Zanella wrote: + ((flags & (GLOB_ERR | GLOB_NOESCAPE | GLOB_ALTDIRFUNC)) + | GLOB_NOSORT | GLOB_ONLYDIR), The indenting is not quite right here: the "|" should be under the 2nd "(" in the previous line, not under the