Re: [PATCH v2] win32: don't force _WIN32_WINNT to a lower version

On 2020-05-28 2:12, Bruno Haible wrote: Hi Steve, Hi Bruno, When building for UWP it's particularly important as a lot of APIs may be hidden if you use the proper values and they are hidden because you shouldn't use them. Forcing to use them when they shouldn't will lead to apps that don't ru

Re: [PATCH v2] win32: don't force _WIN32_WINNT to a lower version

Hi Steve, > When building for UWP it's particularly important as a lot of APIs may > be hidden if you use the proper values and they are hidden because you > shouldn't use them. Forcing to use them when they shouldn't will lead to > apps that don't run. Oh, so Microsoft is not only adding new

Re: [PATCH v2] win32: don't force _WIN32_WINNT to a lower version

Hi, On 2020-05-26 22:38, Bruno Haible wrote: Hi Steve, /* Ensure that declares GetFileSizeEx. */ +#if !defined(_WIN32_WINNT) || _WIN32_WINNT < 0x0500 # undef _WIN32_WINNT # define _WIN32_WINNT _WIN32_WINNT_WIN2K +#endif What do you gain by this? What does it bring to compile

Re: [PATCH v2] win32: don't force _WIN32_WINNT to a lower version

Hi Steve, > > /* Ensure that declares GetFileSizeEx. */ > +#if !defined(_WIN32_WINNT) || _WIN32_WINNT < 0x0500 > # undef _WIN32_WINNT > # define _WIN32_WINNT _WIN32_WINNT_WIN2K > +#endif > What do you gain by this? What does it bring to compile this code with a higher _WIN32_WINNT valu

[PATCH v2] win32: don't force _WIN32_WINNT to a lower version

--- lib/ftruncate.c | 2 ++ lib/sethostname.c | 6 -- lib/stat-w32.c| 6 -- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/lib/ftruncate.c b/lib/ftruncate.c index a1856374e..990b71dbb 100644 --- a/lib/ftruncate.c +++ b/lib/ftruncate.c @@ -30,8 +30,10 @@ argument.