Re: [PATCH 8/8] fts: do not exhaust memory when processing million-entry directories

Bruno Haible wrote: > Hi Jim, > > About this change of fts.c from 2011-08-18. > The declaration of max_entries in line 1339 comes after a statement. Not > valid C99. s/C99/C89/ > gnulib's conventions are still to not require a C99 compiler. Hi Bruno, I see so much more value in using C99's decl

Re: [PATCH 8/8] fts: do not exhaust memory when processing million-entry directories

Hi Jim, About this change of fts.c from 2011-08-18. The declaration of max_entries in line 1339 comes after a statement. Not valid C99. gnulib's conventions are still to not require a C99 compiler. Bruno -- In memoriam Martha Corey

Re: [PATCH 8/8] fts: do not exhaust memory when processing million-entry directories

Jim Meyering wrote: > Paul Eggert wrote: >> Thanks for all that work to make fts better! A couple of minor things >> about comments: >> >> On 08/18/2011 06:53 AM, Jim Meyering wrote: >> >>> + into memory at once. However, When an fts_compar function >> >> The "However," can be removed (

Re: [PATCH 8/8] fts: do not exhaust memory when processing million-entry directories

Paul Eggert wrote: > Thanks for all that work to make fts better! A couple of minor things > about comments: > > On 08/18/2011 06:53 AM, Jim Meyering wrote: > >> + into memory at once. However, When an fts_compar function > > The "However," can be removed (there are too many Buts etc. i

Re: [PATCH 8/8] fts: do not exhaust memory when processing million-entry directories

Thanks for all that work to make fts better! A couple of minor things about comments: On 08/18/2011 06:53 AM, Jim Meyering wrote: > + into memory at once. However, When an fts_compar function The "However," can be removed (there are too many Buts etc. in the neighborhood already ...)

[PATCH 8/8] fts: do not exhaust memory when processing million-entry directories

From: Jim Meyering Before this change, traversing (via rm -rf, find, du, etc.) an N-entry directory would require about 256*N bytes of memory. Thus, it was easy to construct a directory too large to be processed by any of those tools. With this change, the maximum memory utilization is now limi