Re: [PATCH 5/6] test-strftime: test for Solaris bug

2015-12-22 Thread Pádraig Brady
On 22/12/15 21:48, Paul Eggert wrote: > Pádraig Brady wrote: >> Oh Solaris has the same issue? > > Sorry, I thought your earlier messages said so; if not then please ignore my > noise about Solaris. > >> So you mean warn, rather than fail or ignore in this case? > > This depends on whether the

Re: [PATCH 5/6] test-strftime: test for Solaris bug

2015-12-22 Thread Paul Eggert
Pádraig Brady wrote: Oh Solaris has the same issue? Sorry, I thought your earlier messages said so; if not then please ignore my noise about Solaris. So you mean warn, rather than fail or ignore in this case? This depends on whether the failure is due to gnulib (in which case we should f

Re: [PATCH 5/6] test-strftime: test for Solaris bug

2015-12-22 Thread Pádraig Brady
On 22/12/15 16:59, Paul Eggert wrote: > Pádraig Brady wrote: >> The attached patch skips the expected output check, >> for the two ahistorical entries, when tm_isdst is not set, >> and now passes on Darwin 14. > > The ahistorical entries strictly conform to the POSIX spec for TZ settings, > and

Re: [PATCH 5/6] test-strftime: test for Solaris bug

2015-12-22 Thread Paul Eggert
Pádraig Brady wrote: The attached patch skips the expected output check, for the two ahistorical entries, when tm_isdst is not set, and now passes on Darwin 14. The ahistorical entries strictly conform to the POSIX spec for TZ settings, and any POSIX or POSIX-like implementation should handle

Re: [PATCH 5/6] test-strftime: test for Solaris bug

2015-12-22 Thread Pádraig Brady
On 20/12/15 22:15, Pádraig Brady wrote: > Note this fails on x86_64-apple-darwin13.4.0 (mavericks) with: > > FAIL: test-strftime (exit: 1) > = > NZST-12NZDT,M9.5.0,M4.1.0/3: > expected "1970-01-01 13:00:00 +1300 (NZDT)", >got "1970-01-01 12:00:00 +1200 (NZST)"

Re: [PATCH 5/6] test-strftime: test for Solaris bug

2015-12-20 Thread Pádraig Brady
Note this fails on x86_64-apple-darwin13.4.0 (mavericks) with: FAIL: test-strftime (exit: 1) = NZST-12NZDT,M9.5.0,M4.1.0/3: expected "1970-01-01 13:00:00 +1300 (NZDT)", got "1970-01-01 12:00:00 +1200 (NZST)" I've only got access to yosemite (darwin14), but I'l

[PATCH 5/6] test-strftime: test for Solaris bug

2015-07-25 Thread Paul Eggert
* modules/strftime-tests (Depends-on): Add strerror. * tests/test-strftime.c: Include . (posixtm_test): New function, containing the old 'main'. (struct tzalloc_test, struct localtime_rz_test): New types. (TZ, LT): New static vars. (tzalloc_test): New function. (main): Rewrite in terms of posixtm_t