Re: [PATCH 3/4] ptsname_r: port to Solaris

2011-11-08 Thread Bruno Haible
Eric Blake wrote: > + * lib/ptsname_r.c (ptsname_r): Provide wrapper around ptsname, > + when it is available, since Solaris isatty doesn't set errno. > ... > I would expect feedback > to include whether ptsname_r should drag in locking The new ptsname_r replacement is active on platforms

[PATCH 3/4] ptsname_r: port to Solaris

2011-11-07 Thread Eric Blake
Blindly implementing ptsname_r from scratch using the glibc algorithm fails on Solaris 10, where isatty() doesn't set errno when returning 0. While not thread-safe, wrapping ptsname() instead of implementing things ourselves has better results. * m4/ptsname_r.m4 (gl_FUNC_PTSNAME_R): Also check fo