Re: sed, SIGPIPE, cmp -s [Re: [PATCH 3/4] gnulib-tool: abort loops early where possible.

2009-01-01 Thread Jim Meyering
Bruno Haible wrote: >>./bootstrap: Copying ._bootmp/gnulib-tests/Makefile.am to >> gnulib-tests/gnulib.mk... >> -sed: couldn't write 60 items to stdout: Broken pipe >> +sed: couldn't write 56 items to stdout: Broken pipe >> >> I see that it's technically harmless and comes from here: >> >

Re: sed, SIGPIPE, cmp -s [Re: [PATCH 3/4] gnulib-tool: abort loops early where possible.

2009-01-01 Thread Bruno Haible
Hi Jim, >./bootstrap: Copying ._bootmp/gnulib-tests/Makefile.am to > gnulib-tests/gnulib.mk... > -sed: couldn't write 60 items to stdout: Broken pipe > +sed: couldn't write 56 items to stdout: Broken pipe > > I see that it's technically harmless and comes from here: > > sed "$re

Re: [PATCH 3/4] gnulib-tool: abort loops early where possible.

2009-01-01 Thread Bruno Haible
Hello Ralf, > * gnulib-tool (func_modules_add_dummy, func_emit_lib_Makefile_am) > (func_emit_tests_Makefile_am, func_import): Abort loops early if > we already know the answer. Thanks Ralf. According to your timings, this patch provides a noticeable speedup and the code remains pretty. I've appli

sed, SIGPIPE, cmp -s [Re: [PATCH 3/4] gnulib-tool: abort loops early where possible.

2008-12-29 Thread Jim Meyering
Ralf Wildenhues wrote: > * gnulib-tool (func_modules_add_dummy, func_emit_lib_Makefile_am) > (func_emit_tests_Makefile_am, func_import): Abort loops early if > we already know the answer. Hi Ralf, Not that I've reviewed it in detail, but this looks ok. Also, it induces no change in coreutils bui

[PATCH 3/4] gnulib-tool: abort loops early where possible.

2008-12-29 Thread Ralf Wildenhues
* gnulib-tool (func_modules_add_dummy, func_emit_lib_Makefile_am) (func_emit_tests_Makefile_am, func_import): Abort loops early if we already know the answer. --- Sorry, I forgot a couple of instances. Updated patch. Cheers, Ralf gnulib-tool | 20 1 files changed, 8 ins

[PATCH 3/4] gnulib-tool: abort loops early where possible.

2008-12-28 Thread Ralf Wildenhues
* gnulib-tool (func_modules_add_dummy, func_import): Abort loops early if we already know the answer. --- gnulib-tool | 16 ++-- 1 files changed, 6 insertions(+), 10 deletions(-) diff --git a/gnulib-tool b/gnulib-tool index c172d6c..af0726e 100755 --- a/gnulib-tool +++ b/gnulib-tool