Re: [PATCH 20/21] fdopendir: port to OS/2 kLIBC

2014-12-07 Thread KO Myung-Hun
KO Myung-Hun wrote: > > 0001-opendir-closedir-dirfd-fdopendir-port-to-OS-2-kLIBC.patch > Updated. -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http:

Re: [PATCH 20/21] fdopendir: port to OS/2 kLIBC

2014-12-05 Thread KO Myung-Hun
KO Myung-Hun wrote: > > > Paul Eggert wrote: >> KO Myung-Hun wrote: >>> I want to do later separately. No ? >> >> You could put it in a later patch, I suppose, but I wouldn't want to >> install this patch without also installing the later patch. > > Ok. I'll try later. > Done. Review, please

Re: [PATCH 20/21] fdopendir: port to OS/2 kLIBC

2014-12-02 Thread KO Myung-Hun
Paul Eggert wrote: > KO Myung-Hun wrote: >> I want to do later separately. No ? > > You could put it in a later patch, I suppose, but I wouldn't want to > install this patch without also installing the later patch. Ok. I'll try later. -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2

Re: [PATCH 20/21] fdopendir: port to OS/2 kLIBC

2014-12-02 Thread Paul Eggert
KO Myung-Hun wrote: I want to do later separately. No ? You could put it in a later patch, I suppose, but I wouldn't want to install this patch without also installing the later patch.

Re: [PATCH 20/21] fdopendir: port to OS/2 kLIBC

2014-12-02 Thread KO Myung-Hun
Hi/2. Paul Eggert wrote: > KO Myung-Hun wrote: >> /* FIXME: close() fd explicitly after closedir(), or fd leaks */ >> + > > This needs to be fixed. Can't you override closedir? Possible. But I want to do later separately. No ? -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 f

Re: [PATCH 20/21] fdopendir: port to OS/2 kLIBC

2014-12-02 Thread Paul Eggert
KO Myung-Hun wrote: /* FIXME: close() fd explicitly after closedir(), or fd leaks */ + This needs to be fixed. Can't you override closedir?

Re: [PATCH 20/21] fdopendir: port to OS/2 kLIBC

2014-12-02 Thread KO Myung-Hun
Hi/2. Paul Eggert wrote: > On 12/01/2014 11:49 PM, KO Myung-Hun wrote: >> >> First, we don't have copyright assignment from Paul Smedley, so we can't >> install the patch without having that cleared up one way or another. >> >> Which ways ? > > Either get a copyright assignment from Smedley, or r

Re: [PATCH 20/21] fdopendir: port to OS/2 kLIBC

2014-12-02 Thread Paul Eggert
On 12/01/2014 11:49 PM, KO Myung-Hun wrote: First, we don't have copyright assignment from Paul Smedley, so we can't install the patch without having that cleared up one way or another. Which ways ? Either get a copyright assignment from Smedley, or rewrite the change from scratch without us

Re: [PATCH 20/21] fdopendir: port to OS/2 kLIBC

2014-12-01 Thread KO Myung-Hun
Hi/2. Paul Eggert wrote: > KO Myung-Hun wrote: >> * lib/fdopendir.c (fdopendir): Implement on OS/2 kLIBC. >> >> Patches from coreutils 8.8 by Paul Smedley. > > First, we don't have copyright assignment from Paul Smedley, so we can't > install the patch without having that cleared up one way or an

Re: [PATCH 20/21] fdopendir: port to OS/2 kLIBC

2014-11-30 Thread Paul Eggert
KO Myung-Hun wrote: * lib/fdopendir.c (fdopendir): Implement on OS/2 kLIBC. Patches from coreutils 8.8 by Paul Smedley. First, we don't have copyright assignment from Paul Smedley, so we can't install the patch without having that cleared up one way or another. Second, the patch seems to in

[PATCH 20/21] fdopendir: port to OS/2 kLIBC

2014-11-30 Thread KO Myung-Hun
* lib/fdopendir.c (fdopendir): Implement on OS/2 kLIBC. Patches from coreutils 8.8 by Paul Smedley. --- lib/fdopendir.c | 57 + 1 file changed, 57 insertions(+) diff --git a/lib/fdopendir.c b/lib/fdopendir.c index b6c94a0..efe9c7a 100644 --