Re: [PATCH 2/3] scratch_buffer: new module

2017-09-02 Thread Paul Eggert
On 09/02/2017 02:11 AM, Paul Eggert wrote: struct scratch_buffer depends on a GNU C extension: assignment to an object changes its dynamic type.  It is not standard C.   Standard C only allows one way to allocate untyped memory, and that is malloc. That should not be a problem, as Gnulib code

Re: [PATCH 2/3] scratch_buffer: new module

2017-09-02 Thread Paul Eggert
Florian Weimer wrote: This configure test is invalid because __libc_scratch_buffer_grow is a GLIBC_PRIVATE symbol not part of the ABI. You really need to rename those __libc_* functions because they are in the internal glibc namespace. Done by installing the first attached patch into Gnulib. T

Re: [PATCH 2/3] scratch_buffer: new module

2017-09-02 Thread Florian Weimer
On 09/02/2017 01:33 AM, Paul Eggert wrote: > +AC_CHECK_FUNCS_ONCE([__libc_scratch_buffer_grow]) This configure test is invalid because __libc_scratch_buffer_grow is a GLIBC_PRIVATE symbol not part of the ABI. You really need to rename those __libc_* functions because they are in the internal gli

[PATCH 2/3] scratch_buffer: new module

2017-09-01 Thread Paul Eggert
* lib/scratch_buffer.h, lib/scratch_buffer_grow.c: * lib/scratch_buffer_grow_preserve.c: * lib/scratch_buffer_set_array_size.c: New files, copied from glibc with very minor changes that can be copied back. * modules/scratch_buffer: New file. --- ChangeLog | 8 +++ lib/s