Re: [PATCH 2/3] add winsock wrappers

2008-10-05 Thread Bruno Haible
I'm applying these (obvious) tweaks. The 'errno' module is needed because of the reference to EWOULDBLOCK added recently. 2008-10-05 Bruno Haible <[EMAIL PROTECTED]> * lib/winsock.c (strerror): Remove unused #undef. (rpl_close): Remove unused local variable. * modules/s

Re: [PATCH 2/3] add winsock wrappers

2008-09-23 Thread Simon Josefsson
Paolo Bonzini <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> Paolo Bonzini <[EMAIL PROTECTED]> writes: >> >>> Tested together with patch 3/3. Ok? >> >> I haven't tested it, but will do now that it has been installed. >> >> However, just to confirm, the sys_socket module needs to remai

Re: [PATCH 2/3] add winsock wrappers

2008-09-23 Thread Paolo Bonzini
Simon Josefsson wrote: > Paolo Bonzini <[EMAIL PROTECTED]> writes: > >> Tested together with patch 3/3. Ok? > > I haven't tested it, but will do now that it has been installed. > > However, just to confirm, the sys_socket module needs to remain > LGPLv2.1+, and that's what the module descriptio

Re: [PATCH 2/3] add winsock wrappers

2008-09-23 Thread Simon Josefsson
Paolo Bonzini <[EMAIL PROTECTED]> writes: > Tested together with patch 3/3. Ok? I haven't tested it, but will do now that it has been installed. However, just to confirm, the sys_socket module needs to remain LGPLv2.1+, and that's what the module description says, did you intend this for the wi

Re: [PATCH 2/3] add winsock wrappers

2008-09-23 Thread Paolo Bonzini
> The rpl_close wrapper in winsock.c will collide with the one in fchdir.c. > We can work on it after you commit your patch. I'll leave this to you... > Also, I would like to have select() implemented right, as I need it in the > 'msgfilter' program. But that's also for afterwards. ... as a deal

Re: [PATCH 2/3] add winsock wrappers

2008-09-23 Thread Bruno Haible
Hi Paolo, Thanks for this big step ahead! In set_winsock_errno, I think we also need to convert the three possible error values below 100. See http://lists.gnu.org/archive/html/bug-gnulib/2008-09/msg00136.html http://msdn.microsoft.com/en-us/library/ms740668(VS.85).aspx The rpl_close wrapper

[PATCH 2/3] add winsock wrappers

2008-09-22 Thread Paolo Bonzini
There are two changes compared to previous versions of the patch: 1) The socket wrapper calls WSASocket to return a "non-overlapped" socket. Overlapped sockets cannot be read and written with read/write (i.e. Win32 API functions ReadFile/WriteFile), only with ReadFileEx/WriteFileEx -- besides rec