Re: [PATCH 2/2] test pread (using the new init.sh framework)

2009-11-27 Thread Jim Meyering
Simon Josefsson wrote: > Jim, there seems to be some PATH issue causing build failures: > > ../../gltests/test-pread.sh: 6: test-pread: not found > FAIL: test-pread.sh > > See: http://autobuild.josefsson.org/gnulib/log-200911270751109732000.txt Hi Simon, Thanks for the report. How can I reproduce

Re: [PATCH 2/2] test pread (using the new init.sh framework)

2009-11-27 Thread Simon Josefsson
Jim, there seems to be some PATH issue causing build failures: ../../gltests/test-pread.sh: 6: test-pread: not found FAIL: test-pread.sh See: http://autobuild.josefsson.org/gnulib/log-200911270751109732000.txt /Simon

Re: [PATCH 2/2] test pread (using the new init.sh framework)

2009-11-25 Thread Jim Meyering
Eric Blake wrote: > Jim Meyering meyering.net> writes: > >> +++ b/modules/pread-tests >> @@ -0,0 +1,14 @@ >> +Files: >> +tests/test-pread.c >> +tests/init.sh >> + > > Oops. I should have caught this, too. > > make[4]: *** No rule to make target `test-pread.sh', needed by `check-TESTS'. > Stop. >

Re: [PATCH 2/2] test pread (using the new init.sh framework)

2009-11-25 Thread Jim Meyering
Eric Blake wrote: > Jim Meyering meyering.net> writes: > >> #!/bin/sh >> : ${srcdir=.} ${builddir=.} > > According to the autoconf manual, $builddir is rigourously equal to '.', from > within autoconf-generated files (such as Makefile built from Makefile.in). I > can see keeping this line

Re: [PATCH 2/2] test pread (using the new init.sh framework)

2009-11-25 Thread Eric Blake
Jim Meyering meyering.net> writes: > +++ b/modules/pread-tests > @@ -0,0 +1,14 @@ > +Files: > +tests/test-pread.c > +tests/init.sh > + Oops. I should have caught this, too. make[4]: *** No rule to make target `test-pread.sh', needed by `check-TESTS'. Stop. You need to add tests/test-pread.s

Re: [PATCH 2/2] test pread (using the new init.sh framework)

2009-11-25 Thread Eric Blake
Jim Meyering meyering.net> writes: > #!/bin/sh > : ${srcdir=.} ${builddir=.} According to the autoconf manual, $builddir is rigourously equal to '.', from within autoconf-generated files (such as Makefile built from Makefile.in). I can see keeping this line so that you can run the scr

[PATCH 2/2] test pread (using the new init.sh framework)

2009-11-25 Thread Jim Meyering
Notice how this tiny shell script drives the compiled program. There is no need to choose unique names from within the C code, nor even to clean up when done, since it's run from within a just-created directory that's removed upon completion of this single test. Also, there's no more need for the