Re: [PATCH 2/2] posix: Improve randomness on try_tempname_len

2021-01-11 Thread Paul Eggert
On 1/11/21 4:29 AM, Adhemerval Zanella wrote: The idea is to always issue getrandom for __GT_DIR or __GT_FILE on first try, as you suggested initially [1]. I followed your idea [2]:... > [1] https://sourceware.org/pipermail/libc-alpha/2020-September/117535.html [2] https://sourceware.org/pip

Re: [PATCH 2/2] posix: Improve randomness on try_tempname_len

2021-01-11 Thread Adhemerval Zanella
On 08/01/2021 23:20, Paul Eggert wrote: > On 1/4/21 9:03 AM, Adhemerval Zanella wrote: >> For __GT_NOCREATE (mktemp, tempnam, tmpnam) getrandom is also used >> on first try, otherwise randomness is obtained using the clock plus >> a linear congruential generator. > > Why not use getrandom in th

Re: [PATCH 2/2] posix: Improve randomness on try_tempname_len

2021-01-08 Thread Paul Eggert
On 1/4/21 9:03 AM, Adhemerval Zanella wrote: For __GT_NOCREATE (mktemp, tempnam, tmpnam) getrandom is also used on first try, otherwise randomness is obtained using the clock plus a linear congruential generator. Why not use getrandom in the first try also for __GT_DIR (mkdtemp) and __GT_FILE

[PATCH 2/2] posix: Improve randomness on try_tempname_len

2021-01-04 Thread Adhemerval Zanella
For __GT_NOCREATE (mktemp, tempnam, tmpnam) getrandom is also used on first try, otherwise randomness is obtained using the clock plus a linear congruential generator. Also for getrandom GRND_NONBLOCK is used to avoid blocking indefinitely on some older kernels. Checked on x86_64-linux-gnu. ---