Re: [PATCH 2/2] maint: use pragma consistently across replacement headers

Bruno Haible wrote: > Hi Eric, > >> but for the remaining files, we might as >> well satisfy gcc's optimization, since the effort is trivial. >> >> Please apply. > > Applied. > >> Hmm, if we were using cppi more religiously, I wouldn't have introduced >> the whitespace usage in that #if in the firs

Re: [PATCH 2/2] maint: use pragma consistently across replacement headers

Hi Eric, > but for the remaining files, we might as > well satisfy gcc's optimization, since the effort is trivial. > > Please apply. Applied. > Hmm, if we were using cppi more religiously, I wouldn't have introduced > the whitespace usage in that #if in the first place. The file lib/time.in.h

Re: [PATCH 2/2] maint: use pragma consistently across replacement headers

On 03/28/2010 04:35 AM, Bruno Haible wrote: >>> Did you know that GCC has a special optimization for include files? ... > >> are you saying that the optimization is useless for those files, because they >> are split includes, and thus already fail to meet the pattern that gcc >> is looking for? >

Re: [PATCH 2/2] maint: use pragma consistently across replacement headers

Hi Eric, > >> -#ifndef _GL_CTYPE_H > >> - > >> #if __GNUC__ >= 3 > >> @PRAGMA_SYSTEM_HEADER@ > >> #endif > >> > >> +#ifndef _GL_CTYPE_H > >> + > >> /* Include the original . */ > >> /* The include_next requires a split double-inclusion guard. */ > >> #...@include_next@ @NEXT_CTYPE_H@ > >

Re: [PATCH 2/2] maint: use pragma consistently across replacement headers

On 03/25/2010 06:46 PM, Bruno Haible wrote: >> -#ifndef _GL_CTYPE_H >> - >> #if __GNUC__ >= 3 >> @PRAGMA_SYSTEM_HEADER@ >> #endif >> >> +#ifndef _GL_CTYPE_H >> + >> /* Include the original . */ >> /* The include_next requires a split double-inclusion guard. */ >> #...@include_next@ @NEXT_CT

Re: [PATCH 2/2] maint: use pragma consistently across replacement headers

Hi Eric, Eric Blake wrote: > diff --git a/lib/ctype.in.h b/lib/ctype.in.h > index ccf222d..fdf9e1e 100644 > --- a/lib/ctype.in.h > +++ b/lib/ctype.in.h > @@ -23,12 +23,12 @@ > * > */ > > -#ifndef _GL_CTYPE_H > - > #if __G

[PATCH 2/2] maint: use pragma consistently across replacement headers

Several headers set #pragma GCC system_header prior to checking any multiple inclusion guards; maintenance is easiest if all replacement headers follow the same paradigm. * lib/ctype.in.h (system_header): Hoist for consistent placement. * lib/dirent.in.h (system_header): Likewise. * lib/errno.in.h