Re: [PATCH 1/2] Enable more syntax checks, eliminate useless C preprocessor parentheses

2011-06-20 Thread Eric Blake
On 06/18/2011 06:15 PM, Bruno Haible wrote: > James, Eric, >> we're trying to get rid of a findutils construct: >> >> -#if defined SIGCLD && !defined SIGCHLD >> -# define SIGCHLD SIGCLD >> -#endif >> >> and need to know if gnulib's replacement needs to guarantee >> this definition of SIGCHLD, or i

Re: [PATCH 1/2] Enable more syntax checks, eliminate useless C preprocessor parentheses

2011-06-18 Thread Bruno Haible
James, Eric, > we're trying to get rid of a findutils construct: > > -#if defined SIGCLD && !defined SIGCHLD > -# define SIGCHLD SIGCLD > -#endif > > and need to know if gnulib's replacement needs to guarantee > this definition of SIGCHLD, or if the only platforms where only SIGCLD > existed are

Re: [PATCH 1/2] Enable more syntax checks, eliminate useless C preprocessor parentheses

2011-06-13 Thread Eric Blake
[redirecting to bug-gnulib] On 06/13/2011 05:27 PM, James Youngman wrote: > On Mon, Jun 13, 2011 at 4:28 PM, Eric Blake wrote: >> On 06/11/2011 07:42 PM, James Youngman wrote: >>> +++ b/find/find.c > [...] > > Thanks for these comments. They're addressed in the patch "Assume > SIGCHLD and O_NO