On 03/10/15 08:39, Paul Eggert wrote:
> Pádraig Brady wrote:
>> xalloc is
>> included into the coreutils compilation units and so
>> needs this guard.
>
> That's a problem in coreutils, not in gnulib.
Right. I missed the fact it applied only to a single use of xnrealloc.
> Please don't give much
Pádraig Brady wrote:
xalloc is
included into the coreutils compilation units and so
needs this guard.
That's a problem in coreutils, not in gnulib. Please don't give much weight to
those particular compiler warnings. They're often false alarms, as these were.
There is nothing wrong when a
On 02/10/15 21:22, Paul Eggert wrote:
> On 10/02/2015 12:24 PM, Pádraig Brady wrote:
>> +/* GCC 5.1 gives an erroneous warning on 32 bit for xalloc_oversized():
>> + "assuming signed overflow does not occur when simplifying conditional".
>> */
>> +#if (__GNUC__ == 4 && 6 <= __GNUC_MINOR__) || 4
On 10/02/2015 12:24 PM, Pádraig Brady wrote:
+/* GCC 5.1 gives an erroneous warning on 32 bit for xalloc_oversized():
+ "assuming signed overflow does not occur when simplifying conditional". */
+#if (__GNUC__ == 4 && 6 <= __GNUC_MINOR__) || 4 < __GNUC__
+# pragma GCC diagnostic push
+# pragma
* lib/xalloc.h: Disable -Wstrict-overflow for uses of
xalloc_oversized(), which was seen to give this warning
on GCC 5.1 on 32 bit: "assuming signed overflow does not occur
when simplifying conditional".
---
ChangeLog| 8
lib/xalloc.h | 10 ++
2 files changed, 18 insertions(+
