Re: [PATCH] version-etc: extend for packagers

2009-05-31 Thread Mike Frysinger
On Sunday 31 May 2009 04:44:17 Bruno Haible wrote: > Mike Frysinger wrote: > > > +# ifndef PACKAGE_PACKAGER_VERSION > > > +# define PACKAGE_PACKAGER_VERSION "" > > > +# endif > > > > i think it makes sense for this line to read: > > > +# define PACKAGE_PACKAGER_VERSION _("no version info") > > If

Re: [PATCH] version-etc: extend for packagers

2009-05-31 Thread Bruno Haible
Mike Frysinger wrote: > > +# ifndef PACKAGE_PACKAGER_VERSION > > +# define PACKAGE_PACKAGER_VERSION "" > > +# endif > > i think it makes sense for this line to read: > > +# define PACKAGE_PACKAGER_VERSION _("no version info") If there is no version info, why not simply display nothing? #ifdef

Re: [PATCH] version-etc: extend for packagers

2009-05-30 Thread Mike Frysinger
On Sunday 31 May 2009 01:52:13 Mike Frysinger wrote: > +# ifndef PACKAGE_PACKAGER_VERSION > +# define PACKAGE_PACKAGER_VERSION "" > +# endif mmm looks like i lost a change between coreutils/gnulib. i think it makes sense for this line to read: > +# define PACKAGE_PACKAGER_VERSION _("no version

[PATCH] version-etc: extend for packagers

2009-05-30 Thread Mike Frysinger
This adds three new configure options for packagers to utilize: --with-packager="packager name" --with-packager-version="packager-specific version" --with-packager-bug-reports="packager bug reporting" An example with coreutils: $ ./configure \ --with-packager=Gento