Re: [PATCH] vasnprintf: avoid a warning from gcc -Wsign-compare

Hi Jim, We discussed -Wsign-compare on 2008-12-09, without a real conclusion. . > I'm using -Wsign-compare in iwhd, and this is the sole warning But when I build all of gnulib (excluding libunistring and git-merge-changelog) wit

Re: [PATCH] vasnprintf: avoid a warning from gcc -Wsign-compare

Jim Meyering wrote: > Paul Eggert wrote: >> On 06/15/11 08:17, Jim Meyering wrote: >> >>> + vasnprintf: avoid a warning from gcc -Wsign-compare >>> + * lib/vasnprintf.c (VASNPRINTF): Cast a known-positive quantity to >>> + size_t in order to avoid a warning from gcc -Wsign-compare. >> >> Giv

Re: [PATCH] vasnprintf: avoid a warning from gcc -Wsign-compare

Paul Eggert wrote: > On 06/15/11 08:17, Jim Meyering wrote: > >> +vasnprintf: avoid a warning from gcc -Wsign-compare >> +* lib/vasnprintf.c (VASNPRINTF): Cast a known-positive quantity to >> +size_t in order to avoid a warning from gcc -Wsign-compare. > > Given that the context is this

Re: [PATCH] vasnprintf: avoid a warning from gcc -Wsign-compare

On 06/15/11 08:17, Jim Meyering wrote: > + vasnprintf: avoid a warning from gcc -Wsign-compare > + * lib/vasnprintf.c (VASNPRINTF): Cast a known-positive quantity to > + size_t in order to avoid a warning from gcc -Wsign-compare. Given that the context is this: if

[PATCH] vasnprintf: avoid a warning from gcc -Wsign-compare

ssions [-Werror=sign-compare] I know that we don't like to placate compilers, but... Ok to commit? >From 1213c3e195e1bc7def58c044f42d605086dea72d Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 15 Jun 2011 17:14:59 +0200 Subject: [PATCH] vasnprintf: avoid a warning from gcc -Wsign