Re: [PATCH] tests: factor st_ctime-comparison out of two headers

2011-11-20 Thread Ben Pfaff
Simon Josefsson writes: > Ben Pfaff writes: > >> Simon Josefsson writes: >> >>> Bruno Haible writes: >>> Jim Meyering wrote: > -W >>> ... > -Wwrite-strings > -fdiagnostics-show-option Thanks. I've updated my build script to include these for glibc/x86 builds (ex

Re: [PATCH] tests: factor st_ctime-comparison out of two headers

2011-11-20 Thread Jim Meyering
Simon Josefsson wrote: ... > A combination of the two approaches that I've used is this: > > if test "$gl_gcc_warnings" = yes; then > gl_WARN_ADD([-Werror], [WERROR_CFLAGS]) > gl_WARN_ADD([-Wframe-larger-than=112], [WSTACK_CFLAGS]) > > nw="$nw -Wsystem-headers" # Don't let system head

Re: [PATCH] tests: factor st_ctime-comparison out of two headers

2011-11-20 Thread Peter Johansson
On 11/20/11 1:49 PM, Simon Josefsson wrote: > Another approach is to add -Werror last (this is what Eric Blake > suggested on the autoconf mailing list a long time ago), e.g.: > > AC_DEFUN([OVS_ENABLE_WERROR], > [AC_ARG_ENABLE( >[Werror], >[AC_HELP_STRING([--enable-Werror],

Re: [PATCH] tests: factor st_ctime-comparison out of two headers

2011-11-20 Thread Simon Josefsson
Ben Pfaff writes: > Simon Josefsson writes: > >> Bruno Haible writes: >> >>> Jim Meyering wrote: -W >> ... -Wwrite-strings -fdiagnostics-show-option >>> >>> Thanks. I've updated my build script to include these for glibc/x86 builds >>> (except -Werror, which causes a configuratio

Re: [PATCH] tests: factor st_ctime-comparison out of two headers

2011-11-19 Thread Ben Pfaff
Simon Josefsson writes: > Bruno Haible writes: > >> Jim Meyering wrote: >>> -W > ... >>> -Wwrite-strings >>> -fdiagnostics-show-option >> >> Thanks. I've updated my build script to include these for glibc/x86 builds >> (except -Werror, which causes a configuration error already in >> "checking w

Re: [PATCH] tests: factor st_ctime-comparison out of two headers

2011-11-19 Thread Simon Josefsson
Bruno Haible writes: > Jim Meyering wrote: >> -W ... >> -Wwrite-strings >> -fdiagnostics-show-option > > Thanks. I've updated my build script to include these for glibc/x86 builds > (except -Werror, which causes a configuration error already in > "checking whether the compiler works..."). I reco

Re: [PATCH] tests: factor st_ctime-comparison out of two headers

2011-11-19 Thread Bruno Haible
Jim Meyering wrote: > -W > -Wall > -Wattributes > -Wbad-function-cast > -Wbuiltin-macro-redefined > -Wcast-align > -Wcoverage-mismatch > -Wdisabled-optimization > -Werror > -Wformat-security > -Wformat-y2k > -Winit-self > -Winvalid-pch > -Wmissing-declarations > -Wmissing-include-dirs > -Wmissing-n

Re: [PATCH] tests: factor st_ctime-comparison out of two headers

2011-11-19 Thread Jim Meyering
Bruno Haible wrote: >> If we drop the "inline", then any compilation unit that includes >> that header without using the function will get a warning about >> the unused static function. > > Ah right, you have more gcc warnings enabled typically than I do. > > Can you give me the list of warnings op

Re: [PATCH] tests: factor st_ctime-comparison out of two headers

2011-11-19 Thread Bruno Haible
Hi Jim, > If we drop the "inline", then any compilation unit that includes > that header without using the function will get a warning about > the unused static function. Ah right, you have more gcc warnings enabled typically than I do. Can you give me the list of warnings options that you use o

Re: [PATCH] tests: factor st_ctime-comparison out of two headers

2011-11-18 Thread Jim Meyering
Bruno Haible wrote: > Jim Meyering wrote: >> +static inline int >> +ctime_compare (struct stat const *a, struct stat const *b) > > This code uses 'inline'. But the module descriptions > modules/fdutimensat-tests > modules/futimens-tests > modules/utimens-tests > modules/utimensat-tests > d

Re: [PATCH] tests: factor st_ctime-comparison out of two headers

2011-11-18 Thread Bruno Haible
Jim Meyering wrote: > +static inline int > +ctime_compare (struct stat const *a, struct stat const *b) This code uses 'inline'. But the module descriptions modules/fdutimensat-tests modules/futimens-tests modules/utimens-tests modules/utimensat-tests don't contain an AC_REQUIRE([AC_C_INLIN

[PATCH] tests: factor st_ctime-comparison out of two headers

2011-11-17 Thread Jim Meyering
This replaces each of twelve 3-line ASSERT statements with a one-line equivalent. There are still another five in test-l?chown.h, but I've left them as is. >From 14e4d7a5e32a3e88fc41a132918441277928a1e3 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 17 Nov 2011 15:28:55 +0100 Subject: [