Re: [PATCH] tests: exercise two recently-fixed bugs

2012-03-17 Thread Jim Meyering
Paul Eggert wrote: > On 03/16/2012 02:50 PM, Jim Meyering wrote: >> the TABs (maybe required in glibc?) > > Yes, that's right. Currently I'm having problems > getting mktime fixes back into glibc, and one of > the issues is that we expanded tabs to spaces. > What a hassle. I know the pain ;-) but

Re: [PATCH] tests: exercise two recently-fixed bugs

2012-03-16 Thread Paul Eggert
On 03/16/2012 02:50 PM, Jim Meyering wrote: > the TABs (maybe required in glibc?) Yes, that's right. Currently I'm having problems getting mktime fixes back into glibc, and one of the issues is that we expanded tabs to spaces. What a hassle. > I consider grep's choice of when to use regex vs. DF

Re: [PATCH] tests: exercise two recently-fixed bugs

2012-03-16 Thread Jim Meyering
Paul Eggert wrote: >>> > I think we should give a "repeat count too large" error here. The regex >>> > is being compiled to a different meaning than what the user intended. >> Yes, definitely. >> In testing, I noticed that we diagnose the range error >> in the regexp path, but not in the DFA one,

Re: [PATCH] tests: exercise two recently-fixed bugs

2012-03-16 Thread Paul Eggert
>> > I think we should give a "repeat count too large" error here. The regex >> > is being compiled to a different meaning than what the user intended. > Yes, definitely. > In testing, I noticed that we diagnose the range error > in the regexp path, but not in the DFA one, but haven't > gotten aro