Re: [PATCH] test-select: avoid warn_unused_result warnings

Jim Meyering wrote: > That should be ok, assuming no modern version of gcc > warns about the unused value, in spite of the "(void)" cast. Yes, this is the case, because close() is not marked as __wur in glibc's . Bruno

Re: [PATCH] test-select: avoid warn_unused_result warnings

Bruno Haible wrote: > Hi Jim, > > You wrote on 2010-10-13 in > : >> * tests/test-select.c: Include "macros.h". >> ASSERT that each call to read, write, and pipe succeeds. >> While not technically required, also check each "close".

Re: [PATCH] test-select: avoid warn_unused_result warnings

Hi Jim, You wrote on 2010-10-13 in : > * tests/test-select.c: Include "macros.h". > ASSERT that each call to read, write, and pipe succeeds. > While not technically required, also check each "close". The last part causes a failur

Re: [PATCH] test-select: avoid warn_unused_result warnings

Paolo Bonzini wrote: > On 10/13/2010 10:19 AM, Jim Meyering wrote: >> Hi Paolo, >> >> Is this change ok with you? >> Without it, I see many warnings like this when running >> coreutils's "make check" (with --enable-gcc-warnings): >> >> test-select.c: In function 'test_pair': >> test-selec

[PATCH] test-select: avoid warn_unused_result warnings

7;, declared \ with attribute warn_unused_result test-select.c:336: warning: ignoring return value of 'read', declared \ with attribute warn_unused_result >From 589ff057183416c257c98b4364e2ca03ea4feece Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 13 Oct 2010 10

Re: [PATCH] test-select: avoid warn_unused_result warnings

On 10/13/2010 10:19 AM, Jim Meyering wrote: Hi Paolo, Is this change ok with you? Without it, I see many warnings like this when running coreutils's "make check" (with --enable-gcc-warnings): test-select.c: In function 'test_pair': test-select.c:330: warning: ignoring return value of