Re: [PATCH] test-freading: remove a temporary file

2009-11-16 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 11/15/2009 9:21 AM: >> The second unlink is better omitted, since when the message "file operations >> failed" >> message is printed, the user will likely want to inspect the contents of the >> file and fix >> the test. >

Re: [PATCH] test-freading: remove a temporary file

2009-11-15 Thread Jim Meyering
Bruno Haible wrote: >> Without this change, this test's temporary file is left behind every >> time it is run. >> >> Any objection? > > The #include and the first unlink are fine. Thanks, well spotted. > > The second unlink is better omitted, since when the message "file operations > failed" > mes

Re: [PATCH] test-freading: remove a temporary file

2009-11-14 Thread Bruno Haible
Hi Jim, > Without this change, this test's temporary file is left behind every > time it is run. > > Any objection? The #include and the first unlink are fine. Thanks, well spotted. The second unlink is better omitted, since when the message "file operations failed" message is printed, the use

[PATCH] test-freading: remove a temporary file

2009-11-14 Thread Jim Meyering
Hi Bruno, Without this change, this test's temporary file is left behind every time it is run. Any objection? >From 314ab5c4729f34bcb2aca85181091a4f22d98e52 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 14 Nov 2009 13:20:25 +0100 Subject: [PATCH] test-freading: remove a tempor