Re: [PATCH] syntax-check rules to check for links in README

2023-06-06 Thread Jose E. Marchesi
> Jose E. Marchesi wrote: >> > But what I wanted to know is: Now that we know that this patch will cause >> > work to (and may annoy) some people, should I commit it in your name? >> >> Please. > > OK, I pushed it, adding a summary line to the ChangeLog entry: Thank you. > > 2023-06-06 Jose E

Re: [PATCH] syntax-check rules to check for links in README

2023-06-06 Thread Bruno Haible
Jose E. Marchesi wrote: > > But what I wanted to know is: Now that we know that this patch will cause > > work to (and may annoy) some people, should I commit it in your name? > > Please. OK, I pushed it, adding a summary line to the ChangeLog entry: 2023-06-06 Jose E. Marchesi main

Re: [PATCH] syntax-check rules to check for links in README

2023-06-06 Thread Jose E. Marchesi
> José E. Marchesi wrote: >> > Is this your intention? >> >> Yes, if the corresponding requirements of the GCS are still considered >> reasonable and pertinent. >> >> Otherwise, I would say we should update the standard in order to turn >> these requirements into suggestions. > > That's a valid

Re: [PATCH] syntax-check rules to check for links in README

2023-06-06 Thread Bruno Haible
José E. Marchesi wrote: > > Is this your intention? > > Yes, if the corresponding requirements of the GCS are still considered > reasonable and pertinent. > > Otherwise, I would say we should update the standard in order to turn > these requirements into suggestions. That's a valid answer. But

Re: [PATCH] syntax-check rules to check for links in README

2023-06-06 Thread Jose E. Marchesi
> Hi José, > >> +sc_readme_link_install: >> +@require='INSTALL' \ >> +in_vc_files='$(top_srcdir)/README$$'\ >> +halt='The README file should refer to INSTALL' \ >> + $(_sc_search_regexp) > > This rule will whine at

Re: [PATCH] syntax-check rules to check for links in README

2023-06-06 Thread Bruno Haible
Hi José, > +sc_readme_link_install: > + @require='INSTALL' \ > + in_vc_files='$(top_srcdir)/README$$'\ > + halt='The README file should refer to INSTALL' \ > + $(_sc_search_regexp) This rule will whine at least in

Re: [PATCH] syntax-check rules to check for links in README

2023-06-06 Thread Bruno Haible
Pierre Labastie wrote: > IIUC, this is Makefile syntax. If so, there should be semicolons `;' at the > end > of each line (but before the `\'). The 46 existing invocations of $(_sc_search_regexp) don't have semicolons after each variable assignment either. > Otherwise, the shell will be passed >

Re: [PATCH] syntax-check rules to check for links in README

2023-06-05 Thread Pierre Labastie
On Mon, 2023-06-05 at 22:38 +0200, Jose E. Marchesi wrote: > > The GNU Coding Standards says: > > The 'README' file should refer to the file 'INSTALL', which should >   contain an explanation of the installation procedure. > > The 'README' file should also refer to the file which conta

[PATCH] syntax-check rules to check for links in README

2023-06-05 Thread Jose E. Marchesi
The GNU Coding Standards says: The 'README' file should refer to the file 'INSTALL', which should contain an explanation of the installation procedure. The 'README' file should also refer to the file which contains the copying conditions. The GNU GPL, if used, should be in a file