Hi Jim,
> Thanks for those fixes. With those and the three
> multithread-test-disabling changes, I confirm that all of GNU sed's
> tests pass when built using the latest from gcc master (GCC10-pre).
Good. Two other reports of this issue can now be closed:
- in sed: https://debbugs.gnu.org/cgi/b
On Sun, Jan 5, 2020 at 12:47 PM Bruno Haible wrote:
>
> Jim Meyering wrote:
> > > The question is: Is passing NULL to canonicalize_file_name valid? If not,
> > > then the nonnull attribute should stay.
> > >
> > > On one hand, in glibc's stdlib.h we have:
> > >
> > > extern char *canonicalize_file
Jim Meyering wrote:
> > The question is: Is passing NULL to canonicalize_file_name valid? If not,
> > then the nonnull attribute should stay.
> >
> > On one hand, in glibc's stdlib.h we have:
> >
> > extern char *canonicalize_file_name (const char *__name)
> > __THROW __nonnull ((1)) __wur;
>
On Sun, Jan 5, 2020 at 8:41 AM Jim Meyering wrote:
...
> > Does the attached patch fix the problem for you?
>
> Thanks for working on that. However, it did not help, because at least
> on Fedora 30, we're using the system declaration, per this: (run from
> a test dir prepared by "./gnulib-tool --t
On Sun, Jan 5, 2020 at 12:16 AM Bruno Haible wrote:
> Hi Jim,
Hi Bruno,
Thanks for investigating.
> > stdlib: avoid canonicalize_file_name contradiction
> > * lib/stdlib.in.h (canonicalize_file_name): Remove the nonnull
> > attribute from its declaration.
>
> I'm not sure this is right. The patc
Hi Jim,
> stdlib: avoid canonicalize_file_name contradiction
> * lib/stdlib.in.h (canonicalize_file_name): Remove the nonnull
> attribute from its declaration.
I'm not sure this is right. The patch removes a diagnostic (from GCC and
possibly other static analyzers) when some code is, by mistake,
I expect to push something like the attached tomorrow:
stdlib: avoid canonicalize_file_name contradiction
* lib/stdlib.in.h (canonicalize_file_name): Remove the nonnull
attribute from its declaration. tests/test-canonicalize-lgpl.c
passes null_ptr () to it, which (via this contradiction) would
pro
