Re: [PATCH] save-cwd: don't leak a file descriptor when the caller execs.

2010-03-29 Thread Eric Blake
On 03/29/2010 03:49 AM, James Youngman wrote: > Signed-off-by: James Youngman > --- > ChangeLog|7 +++ > lib/save-cwd.c |2 ++ > modules/save-cwd |1 + > 3 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/ChangeLog b/ChangeLog > index dca5a12..f9bd220 10

Re: [PATCH] save-cwd: don't leak a file descriptor when the caller execs.

2010-03-29 Thread Jim Meyering
James Youngman wrote: > + save-cwd: don't leak a file descriptor when the caller execs. > + * lib/save-cwd.c (save_cwd): set the close-on-exec flag for the > + saved file descriptor. > + * modules/save-cwd (Depends-on): Depend on cloexec. Thanks! I've pushed.

Re: [PATCH] save-cwd: don't leak a file descriptor when the caller execs.

2010-03-29 Thread James Youngman
On Mon, Mar 29, 2010 at 11:23 AM, Paolo Bonzini wrote: > On 03/29/2010 11:49 AM, James Youngman wrote: >> >> Signed-off-by: James Youngman > > Good catch, thanks!  Do you have commit access? I don't. Thanks, James.

Re: [PATCH] save-cwd: don't leak a file descriptor when the caller execs.

2010-03-29 Thread Paolo Bonzini
On 03/29/2010 11:49 AM, James Youngman wrote: Signed-off-by: James Youngman Good catch, thanks! Do you have commit access? Paolo

[PATCH] save-cwd: don't leak a file descriptor when the caller execs.

2010-03-29 Thread James Youngman
Signed-off-by: James Youngman --- ChangeLog|7 +++ lib/save-cwd.c |2 ++ modules/save-cwd |1 + 3 files changed, 10 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index dca5a12..f9bd220 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2010-03-2