Hi Benno,
> By staring at the code and trying to understand whether I am missing
> something, why that c == 0xf4 is there.
I see. For consistency with the other occurrences of this idiom
lib/unistr/u8-check.c:66: && (c < 0xf4 || (c == 0xf4 && s[1] <
0x90)))
lib/unistr/u8-mblen.
Op 21-03-2021 om 19:22 schreef Bruno Haible:
> Hi Benno,
>
>> * lib/mbrtowc-impl-utf8.h: There is no need to check for c == 0xf4
>> when !(c < 0xf4), as ten lines earlier c <= 0xf4 was established.
>
> Your patch is correct. But we generally don't need to do micro-
> optimizations that a compile
Hi Benno,
> * lib/mbrtowc-impl-utf8.h: There is no need to check for c == 0xf4
> when !(c < 0xf4), as ten lines earlier c <= 0xf4 was established.
Your patch is correct. But we generally don't need to do micro-
optimizations that a compiler easily can do for us. Just curious:
Did you get a compil
* lib/mbrtowc-impl-utf8.h: There is no need to check for c == 0xf4
when !(c < 0xf4), as ten lines earlier c <= 0xf4 was established.
---
ChangeLog | 6 ++
lib/mbrtowc-impl-utf8.h | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index 76e
