Re: [PATCH] math: Silence -Winclude-next-absolute-path warning.

On 2024-02-19 13:24, Bruno Haible wrote: The larger part of the problem is not with Gnulib, but with the > 100 packages that use Gnulib. Oh, I wasn't proposing that we use the simpler style in all apps, just Gnulib. It's not that big a deal, so let's just leave things be for now. (But if we

Re: [PATCH] math: Silence -Winclude-next-absolute-path warning.

Paul Eggert wrote: > > writing #include <...> everywhere has > > very little benefit. > > There is a benefit: it's simpler and would avoid future problems like > the one just fixed. There is also a drawback: Remember why we took the habit of putting all #include before all #include "applica

Re: [PATCH] math: Silence -Winclude-next-absolute-path warning.

On 2024-02-19 03:03, Bruno Haible wrote: writing #include <...> everywhere has very little benefit. There is a benefit: it's simpler and would avoid future problems like the one just fixed. Currently we have more-complicated guideline, which is that one should use #include <...> for include

Re: [PATCH] math: Silence -Winclude-next-absolute-path warning.

Paul Eggert wrote: > On 2024-02-18 04:19, Bruno Haible wrote: > > +When including including specific header files, you need to use the > > +@samp{#include <...>} syntax, not the @samp{#include "..."} syntax. > > Why does Gnulib source code ever use the #include "..." syntax? Because that's the wa

Re: [PATCH] math: Silence -Winclude-next-absolute-path warning.

On 2024-02-18 04:19, Bruno Haible wrote: +When including including specific header files, you need to use the +@samp{#include <...>} syntax, not the @samp{#include "..."} syntax. Why does Gnulib source code ever use the #include "..." syntax? I don't see why it's helpful, given that one must a

Re: [PATCH] math: Silence -Winclude-next-absolute-path warning.

Collin Funk wrote: > > I also applied this patch, to complete > > : > > Thanks, gettext warns a lot about that header. I'll submit a patch over there > later today. Oh, I now see what you mean. Thanks for the patch. Before appl

Re: [PATCH] math: Silence -Winclude-next-absolute-path warning.

Collin Funk wrote: > gettext warns a lot about that header. I'll submit a patch over there later > today. gettext imports a lot of code from gnulib. Before submitting a patch, check whether the file is present in the gettext git repository [1] (as opposed to the gettext release tarball). If the f

Re: [PATCH] math: Silence -Winclude-next-absolute-path warning.

On 2/17/24 2:51 AM, Bruno Haible wrote: > I also applied this patch, to complete > : Thanks, gettext warns a lot about that header. I'll submit a patch over there later today.

Re: [PATCH] math: Silence -Winclude-next-absolute-path warning.

Collin Funk wrote: > Hello. When compiling gettext from master I get the following warning: > > ./math.h:46:2: warning: #include_next in file found relative to primary > source file or found by absolute path; will search from start of include path > [-Winclude-next-absolute-path] >46 | #incl

[PATCH] math: Silence -Winclude-next-absolute-path warning.

thing. Thanks! CollinFrom 269dfab932a01cfbbb5382b8955f06d065eea149 Mon Sep 17 00:00:00 2001 From: Collin Funk Date: Sat, 17 Feb 2024 00:19:17 -0800 Subject: [PATCH] math: Silence -Winclude-next-absolute-path warning. See commit f4fccf8efdd09d5e38f49f6ae1962797ce3e8e9c for more information. * lib/m