Jim Meyering wrote:
> > - t = pi - acosl(-x);
> > + t = pi - acosl (- x);
>
> For a unary "-", it seems more readable to omit the following space.
ok.
There were no other objections in 4 days, so I committed the patch.
Bruno
Bruno Haible wrote:
> A large part of them are in comments. I would suggest to exempt comments
> (since comments are not code). Like this:
>
> # A sed expression that removes ANSI C and ISO C99 comments.
> # Taken from GNU gettext's 'moopp' preprocessor.
> sed_remove_comments="
> /[/][/*]/{
> ta
Bruno Haible wrote:
>> This leaves 916 occurrences, which is more reasonable (attached below).
>
> Here's a proposal to fix those that IMO ought to be fixed.
>
> Objections?
None from me.
> --- lib/acosl.c.orig Sat Mar 20 18:58:28 2010
> +++ lib/acosl.c Sat Mar 20 17:59:36 2010
> @@ -108,7
> This leaves 916 occurrences, which is more reasonable (attached below).
Here's a proposal to fix those that IMO ought to be fixed.
Objections?
2010-03-20 Bruno Haible
Minor formatting changes.
* lib/acosl.c: Insert space before function argument list.
* lib/argz.c:
Jim Meyering wrote:
> FYI, I've just pushed this to coreutils.
...
>>From 628a5e16ddd28110c506f34667ef993d9be7b837 Mon Sep 17 00:00:00 2001
> From: Jim Meyering
> Date: Sat, 20 Mar 2010 12:14:46 +0100
> Subject: [PATCH 2/2] maint: enforce one small aspect of formatting style:
> space-before-"("
.
Bruno Haible wrote:
>> Any objections?
>
> I cannot reasonably object, because you have not precisely explained what the
> "small aspect of formatting style" is. The subject line says:
> space-before-"(".
> The comment says:
> Ensure that there is a space before each open parenthesis in C code.
Hi Jim,
> Any objections?
I cannot reasonably object, because you have not precisely explained what the
"small aspect of formatting style" is. The subject line says: space-before-"(".
The comment says:
Ensure that there is a space before each open parenthesis in C code.
But there are currently
Eric Blake wrote:
> On 03/20/2010 05:24 AM, Jim Meyering wrote:
>> +_space_before_paren_exempt =? \\n\\$$
>> +_space_before_paren_exempt = \
>> + (\\n\\$$|%s\(to %s|delimit-method|(date|group|character)\(s\))
>> +# Ensure that there is a space before each open parenthesis in C code.
>> +sc_space_b
On 03/20/2010 05:24 AM, Jim Meyering wrote:
> +_space_before_paren_exempt =? \\n\\$$
> +_space_before_paren_exempt = \
> + (\\n\\$$|%s\(to %s|delimit-method|(date|group|character)\(s\))
> +# Ensure that there is a space before each open parenthesis in C code.
> +sc_space_before_open_paren:
> +
FYI, I've just pushed this to coreutils.
Note that I've embedded both a default exemption regexp,
as well as the one I'm using in coreutils.
Obviously only the default would go into gnulib's maint.mk
Eric suggested that I put this in gnulib's maint.mk.
This is a pretty fundamental axiom of formatt
10 matches
Mail list logo
