Re: [PATCH] hamt: New module.

Hi Bruno, Am Mo., 5. Apr. 2021 um 15:02 Uhr schrieb Bruno Haible : > Hi Marc, > > > * tests/test-hamt.c: New file. > > Can you please have a quick look whether these Coverity findings (from our > weekly Coverity run) are relevant? > Coverity seems to be a good tool. I haven't yet tested GCC's ne

Re: [PATCH] hamt: New module.

Hi Marc, > * tests/test-hamt.c: New file. Can you please have a quick look whether these Coverity findings (from our weekly Coverity run) are relevant? *** CID 1503613: Null pointer derefer

Re: [PATCH] hamt: New module.

Hi Marc, > thank you very much for all the helpful feedback. I have incorporated your > suggestions, and you can find an updated diff below. This is definitely better. > +Lookup of a (key, value) pair given the key is an O(1) operation, I forgot to say "on average" here. (It's not worst-case O(

Re: [PATCH] hamt: New module.

Hi Bruno, thank you very much for all the helpful feedback. I have incorporated your suggestions, and you can find an updated diff below. Thanks, Marc diff --git a/doc/containers.texi b/doc/containers.texi index 15c915b93..9bc1ae43d 100644 --- a/doc/containers.texi +++ b/doc/containers.texi @@

Re: [PATCH] hamt: New module.

Hi Marc, > what do you think of the attempt attached below? I believe that technical documentation of a feature should be written to answer the questions in this order: 1. What is it? (Short summary) 2. When would I use it? (Use cases) 3. How do I use it? 4. Further details. The idea is

Re: [PATCH] hamt: New module.

Hi Bruno, what do you think of the attempt attached below? Thanks, Marc diff --git a/doc/containers.texi b/doc/containers.texi index 15c915b93..35caf200c 100644 --- a/doc/containers.texi +++ b/doc/containers.texi @@ -35,6 +35,9 @@ log Gnulib provides several generic container data types. They

Re: [PATCH] hamt: New module.

Hi Marc, > + hamt: New module. > + This module provides (persistent) hash array mapped tries. > + * MODULES.html.sh: Add hamt. > + * lib/hamt.c: New file. > + * lib/hamt.h: New file. > + * modules/hamt: New file. > + * modules/hamt-tests: New file. > + * tests/test-

[PATCH] hamt: New module.

From: Marc Nieper-Wißkirchen This module provides (persistent) hash array mapped tries. * MODULES.html.sh: Add hamt. * lib/hamt.c: New file. * lib/hamt.h: New file. * modules/hamt: New file. * modules/hamt-tests: New file. * tests/test-hamt.c: New file. --- ChangeLog | 11 + MODULES.h