Re: [PATCH] gnulib-tool: avoid 'if ! ...' in conditional dependencies.

2021-03-11 Thread Bruno Haible
Paul Eggert wrote: > > This syntax is not portable in practice, as discussed in the Autoconf > > manual[1]. > > This shouldn't be a issue in configure scripts, since they should > arrange to use a good shell. I confirm: A gnulib testdir created through ./gnulib-tool --create-testdir --dir=../

Re: [PATCH] gnulib-tool: avoid 'if ! ...' in conditional dependencies.

2021-03-09 Thread Paul Eggert
On 3/9/21 7:38 PM, Nick Bowler wrote: The fix is simple; why not fix it? In this case heirloom-sh is not an actual porting target but is merely a tool being used to find portability bugs, and apparently it's generating a false alarm, and I'd rather avoid code churn due to problems that aren'

Re: [PATCH] gnulib-tool: avoid 'if ! ...' in conditional dependencies.

2021-03-09 Thread Nick Bowler
On 2021-03-09, Paul Eggert wrote: > On 3/9/21 6:45 PM, Nick Bowler wrote: >> I routinely use heirloom-sh to suss out shell portability > > Does your project also have a problem on Solaris 10 because its /bin/sh > also doesn't grok "if !"? No idea. I do not presently have the ability to test on S

Re: [PATCH] gnulib-tool: avoid 'if ! ...' in conditional dependencies.

2021-03-09 Thread Paul Eggert
On 3/9/21 6:45 PM, Nick Bowler wrote: I routinely use heirloom-sh to suss out shell portability Does your project also have a problem on Solaris 10 because its /bin/sh also doesn't grok "if !"? If so, how/why does that happen? ./configure is supposed to re-exec with a working shell, and thi

Re: [PATCH] gnulib-tool: avoid 'if ! ...' in conditional dependencies.

2021-03-09 Thread Nick Bowler
On 09/03/2021, Paul Eggert wrote: > On 3/9/21 6:29 PM, Nick Bowler wrote: >> This syntax is not portable in practice, as discussed in the Autoconf >> manual[1]. > > This shouldn't be a issue in configure scripts, since they should > arrange to use a good shell. If that isn't happening for some rea

Re: [PATCH] gnulib-tool: avoid 'if ! ...' in conditional dependencies.

2021-03-09 Thread Paul Eggert
On 3/9/21 6:29 PM, Nick Bowler wrote: This syntax is not portable in practice, as discussed in the Autoconf manual[1]. This shouldn't be a issue in configure scripts, since they should arrange to use a good shell. If that isn't happening for some reason I'd rather fix the underlying problem t

[PATCH] gnulib-tool: avoid 'if ! ...' in conditional dependencies.

2021-03-09 Thread Nick Bowler
When using the conditional dependencies feature of Gnulib, several functions are emitted into configure scripts that use 'if ! ...'. This syntax is not portable in practice, as discussed in the Autoconf manual[1]. Because in this instance the construct is emitted into configure scripts, this has