Re: [PATCH] fix build failure with getline.c

2010-01-02 Thread Robert Millan
On Sat, Jan 02, 2010 at 10:15:46AM +0100, Simon Josefsson wrote: > Eric Blake writes: > > > According to Robert Millan on 1/1/2010 4:24 PM: > >>> Aren't you using the gnulib stdio module, or is the code not working > >>> somehow? > >>> > >> So no, the stdio module wasn't being included. Maybe yo

Re: [PATCH] fix build failure with getline.c

2010-01-02 Thread Simon Josefsson
Eric Blake writes: > According to Robert Millan on 1/1/2010 4:24 PM: >>> Aren't you using the gnulib stdio module, or is the code not working >>> somehow? >>> >> So no, the stdio module wasn't being included. Maybe you want to consider >> removing this dependency, I think other projects could be

Re: [PATCH] fix build failure with getline.c

2010-01-01 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Robert Millan on 1/1/2010 4:24 PM: >> Aren't you using the gnulib stdio module, or is the code not working >> somehow? >> > So no, the stdio module wasn't being included. Maybe you want to consider > removing this dependency, I think othe

Re: [PATCH] fix build failure with getline.c

2010-01-01 Thread Robert Millan
On Fri, Jan 01, 2010 at 11:45:19PM +0100, Simon Josefsson wrote: > Robert Millan writes: > > > When importing getline.c into GNU GRUB, it failed to build due to undefined > > ssize_t. Here's a fix (I believe including is portable > > enough, > > please let me know if I'm wrong). > > I don't y

Re: [PATCH] fix build failure with getline.c

2010-01-01 Thread Robert Millan
Eric Blake writes: > Which platform was this failure on? Perhaps it resulted from > Bruno's attempts to reduce namespace pollution on glibc machines, coupled > with an older glibc that didn't yet expose everything required by POSIX 2008? Debian Lenny with glibc 2.7. -- Robert Millan "Be the

Re: [PATCH] fix build failure with getline.c

2010-01-01 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Simon Josefsson on 1/1/2010 3:43 PM: >> with an older glibc that didn't yet expose everything required by POSIX 2008? > > Is there really a requirement for stdio.h to define ssize_t? Glibc's > stdio.h doesn't define ssize_t: Yes, POSIX

Re: [PATCH] fix build failure with getline.c

2010-01-01 Thread Simon Josefsson
Robert Millan writes: > When importing getline.c into GNU GRUB, it failed to build due to undefined > ssize_t. Here's a fix (I believe including is portable enough, > please let me know if I'm wrong). I don't your this patch is the right solution -- the gnulib getline module depends on the std

Re: [PATCH] fix build failure with getline.c

2010-01-01 Thread Simon Josefsson
Eric Blake writes: > According to Robert Millan on 1/1/2010 5:56 AM: >> When importing getline.c into GNU GRUB, it failed to build due to undefined >> ssize_t. Here's a fix (I believe including is portable enough, >> please let me know if I'm wrong). > > Hmm. The prototype for getline lives in

Re: [PATCH] fix build failure with getline.c

2010-01-01 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Robert Millan on 1/1/2010 5:56 AM: > When importing getline.c into GNU GRUB, it failed to build due to undefined > ssize_t. Here's a fix (I believe including is portable enough, > please let me know if I'm wrong). Hmm. The prototype fo

[PATCH] fix build failure with getline.c

2010-01-01 Thread Robert Millan
When importing getline.c into GNU GRUB, it failed to build due to undefined ssize_t. Here's a fix (I believe including is portable enough, please let me know if I'm wrong). -- Robert Millan "Be the change you want to see in the world" -- Gandhi 2010-01-01 Robert Millan * lib/getline.c: