Re: [PATCH] file-has-acl: new module, split from acl

2015-06-01 Thread Pádraig Brady
On 28/04/15 12:45, Andreas Grünbacher wrote: > 2015-04-26 20:06 GMT+02:00 Tom G. Christensen : >> On 26/04/15 18:22, Paul Eggert wrote: >>> >>> Thanks for reporting that. I installed the attached patch, which should >>> fix it. >> >> >> Confirmed, thanks. > > I would rather have gnulib define XAT

Re: [PATCH] file-has-acl: new module, split from acl

2015-04-28 Thread Paul Eggert
On 04/28/2015 01:49 PM, Andreas Grünbacher wrote: Hmm well, you are probably right that gl_FUNC_ACL does get called before gl_FILE_HAS_ACL. But the order should be deterministic in any case, no? Yes, so the code in acl.m4 can be simplified accordingly (it's not buggy, just overly complex).

Re: [PATCH] file-has-acl: new module, split from acl

2015-04-28 Thread Andreas Grünbacher
2015-04-28 22:28 GMT+02:00 Paul Eggert : >> Function gl_FILE_HAS_ACL depends on gl_FUNC_ACL to be called >> afterwards, and gl_FUNC_ACL does get called through the gnulib module >> dependencies. Now why is LIB_HAS_ACL being set in both functions? >> > I worried that gl_FILE_HAS_ACL might be invoked

Re: [PATCH] file-has-acl: new module, split from acl

2015-04-28 Thread Paul Eggert
On 04/28/2015 04:45 AM, Andreas Grünbacher wrote: I would rather have gnulib define XATTR_NAME_POSIX_ACL_ACCESS and XATTR_NAME_POSIX_ACL_DEFAULT when the kernel headers don't provide them: I don't know the Linux kernel that well, but if it sounds good to you Function gl_FILE_HAS_ACL depen

Re: [PATCH] file-has-acl: new module, split from acl

2015-04-28 Thread Andreas Grünbacher
2015-04-26 20:06 GMT+02:00 Tom G. Christensen : > On 26/04/15 18:22, Paul Eggert wrote: >> >> Thanks for reporting that. I installed the attached patch, which should >> fix it. > > > Confirmed, thanks. I would rather have gnulib define XATTR_NAME_POSIX_ACL_ACCESS and XATTR_NAME_POSIX_ACL_DEFAULT

Re: [PATCH] file-has-acl: new module, split from acl

2015-04-26 Thread Tom G. Christensen
On 26/04/15 18:22, Paul Eggert wrote: Thanks for reporting that. I installed the attached patch, which should fix it. Confirmed, thanks. -tgc

Re: [PATCH] file-has-acl: new module, split from acl

2015-04-26 Thread Paul Eggert
Thanks for reporting that. I installed the attached patch, which should fix it. >From fc35d110d1bd3ddd4baffdf7a9f8368fec34b542 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 26 Apr 2015 09:20:34 -0700 Subject: [PATCH] file-has-acl: port to CentOS 6 Problem reported by Tom G. Christensen

Re: [PATCH] file-has-acl: new module, split from acl

2015-04-26 Thread Tom G. Christensen
On 25/04/15 07:25, Paul Eggert wrote: And add a new module file-has-acl-tests to match. This does not build for me on CentOS 6. gcc -std=gnu99 -g -O2 -Wall -o test-file-has-acl test-file-has-acl.o ../gllib/libgnu.a -lm -lm -lm -lm -lm -lm -lm -lm -lm -lm -lm ../gllib/libgnu.a(file-has-ac

Re: [PATCH] file-has-acl: new module, split from acl

2015-04-25 Thread Pádraig Brady
On 25/04/15 06:25, Paul Eggert wrote: > And add a new module file-has-acl-tests to match. > I ran into a problem with the recent changes to the acl module, > as they introduced a typo 'test use_xattrs = 0' into 'configure'. Good catch. > When using the fixed version with Emacs, I discovered that

[PATCH] file-has-acl: new module, split from acl

2015-04-24 Thread Paul Eggert
And add a new module file-has-acl-tests to match. I ran into a problem with the recent changes to the acl module, as they introduced a typo 'test use_xattrs = 0' into 'configure'. When using the fixed version with Emacs, I discovered that file-has-acl wasn't separated out well enough for Emacs (e.g