Re: [PATCH] exclude: fix the case of globs vs. EXCLUDE_INCLUDE

2010-03-29 Thread Javier Villavicencio
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 On 03/29/2010 02:56 AM, Jim Meyering wrote: > Javier Villavicencio wrote: >> I think you may have mixed up the two patches I reported against grep > > Think again ;-) :+) I just did, you're right. > >> bug 29358, so, to clarify: >> That above

Re: [PATCH] exclude: fix the case of globs vs. EXCLUDE_INCLUDE

2010-03-28 Thread Jim Meyering
Javier Villavicencio wrote: > I think you may have mixed up the two patches I reported against grep Think again ;-) > bug 29358, so, to clarify: > That above is actually the patch that made most sense to me against the > EXCLUDE_INCLUDE logic, as in: excluded_file_pattern_p should return > !exclu

Re: [PATCH] exclude: fix the case of globs vs. EXCLUDE_INCLUDE

2010-03-28 Thread Javier Villavicencio
31a3459f66a Mon Sep 17 00:00:00 2001 > From: Javier Villavicencio > Date: Sun, 28 Mar 2010 20:42:01 +0200 > Subject: [PATCH] exclude: fix the case of globs vs. EXCLUDE_INCLUDE > > * lib/exclude.c (excluded_file_pattern_p): Fix logic error that > made it so grep -r --include

[PATCH] exclude: fix the case of globs vs. EXCLUDE_INCLUDE

2010-03-28 Thread Jim Meyering
I expect to push this tiny patch by Javier (Cc'd). Thanks, Javier! Without it, grep's --include=GLOB doesn't work. >From efd2b17d1431399233caa5e5b55c831a3459f66a Mon Sep 17 00:00:00 2001 From: Javier Villavicencio Date: Sun, 28 Mar 2010 20:42:01 +0200 Subject: [PATCH] exclud