Re: [PATCH] diffseq: port to clang 18.1.6 in ‘patch’

2024-08-26 Thread Paul Eggert
On 2024-08-26 00:17, Sam James wrote: It would happen on mandriva where they patch their Clang to identify as newer GCC. It can also happen in Fedora or Ubuntu if you configure with CC='clang -fgnuc-version=14.2.1'. Not clear whether we need to support that sort of thing.

Re: [PATCH] diffseq: port to clang 18.1.6 in ‘patch’

2024-08-26 Thread Sam James
Bruno Haible writes: > Sam James wrote: >> It would happen on mandriva ... > > Mandriva is dead [1][2][3]. > > Did you mean OpenMandriva Lx? Or Mageia? Or ROSA? Sorry, bad old habits. OpenMandriva Lx is what you want: * https://github.com/OpenMandrivaAssociation/llvm/blob/master/clang-default-n

Re: [PATCH] diffseq: port to clang 18.1.6 in ‘patch’

2024-08-26 Thread Bruno Haible
Sam James wrote: > It would happen on mandriva ... Mandriva is dead [1][2][3]. Did you mean OpenMandriva Lx? Or Mageia? Or ROSA? Bruno [1] https://en.wikipedia.org/wiki/Mandriva [2] https://distrowatch.com/table.php?distribution=mandriva [3] https://www.mandriva.com

Re: [PATCH] diffseq: port to clang 18.1.6 in ‘patch’

2024-08-26 Thread Bruno Haible
Sam James wrote: > It would happen on mandriva where they patch their Clang to identify as > newer GCC. That's an interesting info. Let me run a gnulib testdir on that platform... Thanks! Bruno

Re: [PATCH] diffseq: port to clang 18.1.6 in ‘patch’

2024-08-26 Thread Sam James
Paul Eggert writes: > On 2024-08-24 09:05, Bruno Haible wrote: >> So, when we have a conditional that tests for GCC >= 4.7 or 10 or 14, >> we don't need to exclude clang, because it's already excluded. > > Weird. I can no longer reproduce the problem with clang. So I undid > that change. If the p

Re: [PATCH] diffseq: port to clang 18.1.6 in ‘patch’

2024-08-25 Thread Paul Eggert
On 2024-08-24 09:05, Bruno Haible wrote: So, when we have a conditional that tests for GCC >= 4.7 or 10 or 14, we don't need to exclude clang, because it's already excluded. Weird. I can no longer reproduce the problem with clang. So I undid that change. If the problem happens again I'll be mo

Re: [PATCH] diffseq: port to clang 18.1.6 in ‘patch’

2024-08-24 Thread Bruno Haible
Hi Paul, > -#if 4 <= __GNUC__ + (7 <= __GNUC_MINOR__) > +#if 4 <= __GNUC__ + (7 <= __GNUC_MINOR__) && !__clang__ Why is this needed? clang 18 still masquerades as a GCC 4.2.1 compatible compiler: $ : | clang -E -dM - | grep __GNUC_ #define __GNUC_MINOR__ 2 #define __GNUC_PATCHLEVEL__ 1 #define _

[PATCH] diffseq: port to clang 18.1.6 in ‘patch’

2024-08-24 Thread Paul Eggert
* lib/diffseq.h: Omit the pragmas if __clang__. --- ChangeLog | 5 + lib/diffseq.h | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 1c9e76d63d..29c02f5478 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2024-08-24 Paul Eggert +