Re: [PATCH] better explain functions [q]set-acl.c

Hi Ondrej, > Improve comments for both functions > > --- > lib/qset-acl.c | 16 +--- > lib/set-acl.c | 13 +++-- > 2 files changed, 16 insertions(+), 13 deletions(-) I wanted to apply this patch in your name, but it fails: error: corrupt patch at line 31 Evidently the patc

[PATCH] better explain functions [q]set-acl.c

Improve comments for both functions --- lib/qset-acl.c | 16 +--- lib/set-acl.c | 13 +++-- 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/lib/qset-acl.c b/lib/qset-acl.c index c3442d060f..0ae026f031 100644 --- a/lib/qset-acl.c +++ b/lib/qset-acl.c @@ -27,13

Re: [PATCH] better explain functions [q]set-acl.c

Hi Ondrej, > Improve comments for both functions Did you see the feedback that I gave in https://lists.gnu.org/archive/html/bug-gnulib/2023-01/msg00063.html ? Bruno

[PATCH] better explain functions [q]set-acl.c

Improve comments for both functions --- lib/qset-acl.c | 16 +--- lib/set-acl.c | 13 +++-- 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/lib/qset-acl.c b/lib/qset-acl.c index c3442d060f..0ae026f031 100644 --- a/lib/qset-acl.c +++ b/lib/qset-acl.c @@ -27,13

Re: [PATCH] better explain functions [q]set-acl.c

Ondrej Valousek wrote: > +/* Set the access control lists of a file to match EXACTLY mode (this might In function comments, by convention we refer to parameters by uppercasing their name. So, this line should probably better read /* Set the access control lists of a file to match *exactly* MOD

[PATCH] better explain functions [q]set-acl.c

Improve comments for both functions --- lib/qset-acl.c | 16 +--- lib/set-acl.c | 13 +++-- 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/lib/qset-acl.c b/lib/qset-acl.c index c3442d060f..0ae026f031 100644 --- a/lib/qset-acl.c +++ b/lib/qset-acl.c @@ -27,13