00 2001
From: Kamil Dudka <[EMAIL PROTECTED]>
Date: Sat, 27 Sep 2008 13:14:34 +
Subject: [PATCH] add new module filevercmp
* lib/filevercmp.h: New function filevercmp comparing version strings.
* lib/filevercmp.c: Implementation of filevercmp function.
* modules/filevercmp: Module metadata.
*
Bruno Haible <[EMAIL PROTECTED]> wrote:
> Jim Meyering wrote:
>> To have any hope of sanity/reproducibility in different locales,
>> this function must return the same result, regardless of the current
>> locale settings.
>
> Yes. In the opposite case, if the function was to handle non-ASCII letter
Jim Meyering wrote:
> To have any hope of sanity/reproducibility in different locales,
> this function must return the same result, regardless of the current
> locale settings.
Yes. In the opposite case, if the function was to handle non-ASCII letters
like ASCII letters, it should also have a code
Kamil Dudka <[EMAIL PROTECTED]> wrote:
> thank you for review. I've made the changes you requested, new patch attached.
Hi Kamil,
I see a warning due to unnecessary test module dependent:
$ ./gnulib-tool --dir /tmp/pm --create-testdir --with-tests --test filevercmp
warning: module filevercmp
Kamil Dudka <[EMAIL PROTECTED]> wrote:
> On Wednesday 24 September 2008 22:52:00 Jim Meyering wrote:
... if (!strcmp (s1, s2))
>> > + int rc = verrevcmp (s1, s1_len, s2, s2_len);
>> > + return (rc == 0)
>> > +/* return 0 if (and only if) strings S1 and S2 are identical */
>> > +? strcm
Hello Bruno,
thank you for review. I've attempted to cover all your suggestions.
On Thursday 25 September 2008 02:18:50 Bruno Haible wrote:
> Some systems still don't have C99 compilers. Therefore you cannot use
> variable declarations after statements. Either collect the variable
> declarations
", "0") < 0); */
>
> Likewise.
I removed both of them completely since there are a bit confusing in the
context of filevercmp. It ignores leading zeros and if the versions are
equal, strcmp is used to distinguish theirs (deterministic) order.
Hopefully I didn't forget
Hello Kamil,
Another set of comments:
> There are still opened some licensing issues as we are now waiting for reply
> from original author.
Yes, we need to wait for this to be clear first.
> Could somebody provide me with a complete set of gcc parameters to catch all
> unportable code in th
n-line:
> From 842bccfc33b46570b73956e39be8c0d9c064453b Mon Sep 17 00:00:00 2001
> From: Kamil Dudka <[EMAIL PROTECTED]>
> Date: Wed, 24 Sep 2008 16:01:57 +0200
> Subject: [PATCH] add new module filevercmp
>
> * lib/filevercmp.h: New function FILEVERCMP comparing version strings
> (and file
gcc parameters to catch all
unportable code in this module? Thanks in advance.
Kamil
From 842bccfc33b46570b73956e39be8c0d9c064453b Mon Sep 17 00:00:00 2001
From: Kamil Dudka <[EMAIL PROTECTED]>
Date: Wed, 24 Sep 2008 16:01:57 +0200
Subject: [PATCH] add new module filevercmp
* lib/filev
10 matches
Mail list logo
