Re: [PATCH] Suggestion: new module link

2009-01-20 Thread Bruno Haible
Hello Martin, Your patch did a '#define _WIN32_WINNT 0x0500' in order to access the CreateHardLink() function. This means, this function did not exist on Windows NT 4. Unfortunately, my mingw test system is running in a Windows NT 4 SP5 machine; this is the only version of Windows that I can use

Re: [PATCH] Suggestion: new module link

2009-01-20 Thread Bruno Haible
Oops, this code does not compile on mingw: > --- tests/test-link.c.orig2009-01-20 01:17:22.0 +0100 > +++ tests/test-link.c 2009-01-20 01:13:52.0 +0100 > @@ -18,6 +18,7 @@ > > #include > > +#include > #include > #include > > @@ -36,8 +37,20 @@ > int > main (int ar

Re: [PATCH] Suggestion: new module link

2009-01-19 Thread Bruno Haible
Hello Eric, Martin, > > Or print a message and return 77, to skip the test, if the current fs > > doesn't support links at this point (such as FAT). > > I'd like to do that, but it it not easy to detect this condition. POSIX > does not specify an error code for it, Linux uses EPERM (which can als

Re: [PATCH] Suggestion: new module link

2009-01-19 Thread Bruno Haible
Hello Martin, Thanks for the test. I committed it with minor tweaks: - Add comments to the shell script. - In the .c file, include . By convention, in gnulib, we include the specification header file right after config.h. In some situations, this allows to uncover bugs. - In the .c f

Re: [PATCH] Suggestion: new module link

2009-01-19 Thread Martin Lambers
Hello Eric! On Mon, 19. Jan 2009, 05:57:14 -0700, Eric Blake wrote: > > The minimal test is probably to > > - create one file, > > - use link() to create a new name for it, > > Or print a message and return 77, to skip the test, if the current fs > doesn't support links at this point (such as

Re: [PATCH] Suggestion: new module link

2009-01-19 Thread Martin Lambers
Hello Bruno, On Sun, 18. Jan 2009, 19:42:11 +0100, Bruno Haible wrote: > Can you please also provide a unit test for this module? > The minimal test is probably to > - create one file, > - use link() to create a new name for it, > - then verify that the contents is the same, > - then modif

Re: [PATCH] Suggestion: new module link

2009-01-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 1/18/2009 11:42 AM: > Hello Martin, > > Can you please also provide a unit test for this module? > The minimal test is probably to > - create one file, > - use link() to create a new name for it, Or print a message an

Re: [PATCH] Suggestion: new module link

2009-01-18 Thread Martin Lambers
On Sun, 18. Jan 2009, 19:33:50 +0100, Bruno Haible wrote: > Your patch looks quite fine. I have applied it with this ChangeLog entry Thank you. > - Don't initialize GNULIB_UNLINK or HAVE_UNLINK - this is unrelated. Sorry, this was a leftover of an unrelated patch. > - In the module descript

Re: [PATCH] Suggestion: new module link

2009-01-18 Thread Bruno Haible
Hello Martin, Can you please also provide a unit test for this module? The minimal test is probably to - create one file, - use link() to create a new name for it, - then verify that the contents is the same, - then modify the contents of the first one, - then verify the contents is agai

Re: [PATCH] Suggestion: new module link

2009-01-18 Thread Bruno Haible
Hello, Martin Lambers wrote: > I'd like to suggest a new module 'link' that provides the link(2) > function for MinGW. Your patch looks quite fine. I have applied it with this ChangeLog entry 2009-01-18 Martin Lambers New module 'link'. * lib/unistd.in.h (link): New declarati

[PATCH] Suggestion: new module link

2009-01-18 Thread Martin Lambers
I'd like to suggest a new module 'link' that provides the link(2) function for MinGW. The module is modelled after the existing fsync module. Martin --- lib/link.c | 83 +++ lib/unistd.in.h | 17 +++ m4/link.m4 | 19