Re: [PATCH] Slightly nicer largefile, year2038 tests

2023-04-23 Thread Paul Eggert
Sorry, I sent that old patch to the mailing list by mistake.

[PATCH] Slightly nicer largefile, year2038 tests

2023-04-23 Thread Paul Eggert
* modules/largefile-tests, modules/year2038-tests (Depends-on): Add assert-h, intprops. * tests/test-largefile.c, tests/test-year2038.c: Prefer compile-time to run-time tests. Don’t assume CHAR_BIT == 8. --- ChangeLog | 9 + modules/largefile-tests | 2 ++ modules/year2038-

Re: [PATCH] Slightly nicer largefile, year2038 tests

2023-04-18 Thread Bruno Haible
Paul Eggert wrote: > I thought that since some of the other tests already use static_assert, > these tests could do so too. The difference is: If one of the other static_assert invocations fails and leads to a compilation error, we can and will fix it as soon as it gets reported. Whereas when a p

Re: [PATCH] Slightly nicer largefile, year2038 tests

2023-04-18 Thread Paul Eggert
Oh, I didn't know that the test harness assumes dynamic checking. I thought that since some of the other tests already use static_assert, these tests could do so too. It's obviously no big deal to revert to dynamic checking and I installed the attached.From a0ef641461085fece13cdf048e7882ba9eac

Re: [PATCH] Slightly nicer largefile, year2038 tests

2023-04-17 Thread Bruno Haible
Hi Paul, > + Don’t assume CHAR_BIT == 8. I can agree with that... > * tests/test-largefile.c, tests/test-year2038.c: > Prefer compile-time to run-time tests. ... but not with that. I wrote in the comments: This test fails if AC_SYS_YEAR2038 could not arrange for a time_t that support

[PATCH] Slightly nicer largefile, year2038 tests

2023-04-17 Thread Paul Eggert
* modules/largefile-tests, modules/year2038-tests (Depends-on): Add assert-h, intprops. * tests/test-largefile.c, tests/test-year2038.c: Prefer compile-time to run-time tests. Don’t assume CHAR_BIT == 8. --- ChangeLog | 9 + modules/largefile-tests | 2 ++ modules/year2038-