Re: [PATCH] Portability fix for GNU make 3.79.1.

2008-08-04 Thread Eric Blake
Ralf Wildenhues gmx.de> writes: > > $ make -C build distcheck > > make: Entering directory `/home/eblake/m4/build' > > GNUmakefile:76: *** commands commence before first target. Stop. > > Which make version is that? $ make --version | head -n1 GNU Make 3.81 > > Thanks, and sorry about this g

Re: [PATCH] Portability fix for GNU make 3.79.1.

2008-08-04 Thread Ralf Wildenhues
Hi Eric, * Eric Blake wrote on Mon, Aug 04, 2008 at 08:42:45PM CEST: > Ralf Wildenhues gmx.de> writes: > > > > * top/GNUmakefile: Avoid 'else COND', which older GNU make > > versions do not understand. > This patch causes problems: > > $ make -C build distcheck > make: Entering directory `/hom

Re: [PATCH] Portability fix for GNU make 3.79.1.

2008-08-04 Thread Eric Blake
Ralf Wildenhues gmx.de> writes: > > * top/GNUmakefile: Avoid 'else COND', which older GNU make > versions do not understand. > --- > Hello Jim, > > OK to apply? This patch causes problems: $ make -C build distcheck make: Entering directory `/home/eblake/m4/build' GNUmakefile:76: *** commands

Re: [PATCH] Portability fix for GNU make 3.79.1.

2008-08-02 Thread Jim Meyering
Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > * top/GNUmakefile: Avoid 'else COND', which older GNU make > versions do not understand. > OK to apply? Hi Ralf, Sure. FYI (to other readers), other than indentation changes, this just inserts a newline in the "else ifneq..." line and adds the then-r

[PATCH] Portability fix for GNU make 3.79.1.

2008-08-02 Thread Ralf Wildenhues
* top/GNUmakefile: Avoid 'else COND', which older GNU make versions do not understand. --- Hello Jim, OK to apply? Thanks, Ralf top/GNUmakefile | 26 ++ 1 files changed, 14 insertions(+), 12 deletions(-) diff --git a/top/GNUmakefile b/top/GNUmakefile index ea5e72c..8b