Re: [PATCH] Fix $m4dirs count

2009-11-14 Thread Robert Millan
On Sat, Nov 14, 2009 at 06:47:15AM -0700, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to Robert Millan on 11/9/2009 2:00 PM: > >> This is wrong, since 'echo -n' is not portable. It should use printf > >> instead, > >> or find some other portable way to coun

Re: [PATCH] Fix $m4dirs count

2009-11-14 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Robert Millan on 11/9/2009 2:00 PM: >> This is wrong, since 'echo -n' is not portable. It should use printf >> instead, >> or find some other portable way to count $m4dirs. > > Hi, > > In that case, please use printf. It should work

Re: [PATCH] Fix $m4dirs count

2009-11-09 Thread Robert Millan
> This is wrong, since 'echo -n' is not portable. It should use printf > instead, > or find some other portable way to count $m4dirs. Hi, In that case, please use printf. It should work too. (I assume it's not necessary to send a new patch, let me know if you'd like me to) -- Robert Millan

Re: [PATCH] Fix $m4dirs count

2009-11-09 Thread Eric Blake
Robert Millan aybabtu.com> writes: > $m4dirs is incorrectly counting. In my particular case > (correct value: 0, detected value: 1), this resulted in gnulib-tool > silently exitting with no visible error (and no job done). > > - m4dirs_count=`echo "$m4dirs" | wc -l` > + m4dirs

[PATCH] Fix $m4dirs count

2009-11-09 Thread Robert Millan
$m4dirs is incorrectly counting. In my particular case (correct value: 0, detected value: 1), this resulted in gnulib-tool silently exitting with no visible error (and no job done). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may acc