Paul Eggert wrote:
> Thanks, that looks good to me too.
Thanks for the review. I've pushed it.
Bruno
Thanks, that looks good to me too.
> A second, separate patch could be applied to reduce the number of uses
> of the term "Woe32" (optional).
Here's the proposed patch to remove most uses of "Woe32".
2012-01-06 Bruno Haible
Talk about "native Windows API", not "Woe32".
* lib/accept4.c: Update comments to menti
On 01/04/12 05:43, Bruno Haible wrote:
>> * lib/poll.c mentions "Win9x" and "WinXP".
>> * lib/select.c is similar.
>
> Agreed.
OK, thanks, I pushed those comment changes.
> I'm really not a fan of rewriting history.
Nor am I, and I guess you're right that it's not worth it here.
I left that
Paul Eggert wrote:
> > Here's my counter-proposal (attached).
>
> Thanks, that looks pretty good.
OK, I've committed that.
> I see three files that still need work, though:
>
> * lib/poll.c mentions "Win9x" and "WinXP".
> * lib/select.c is similar.
Agreed.
> * ChangeLog entries needed.
>
On 01/02/12 15:59, Bruno Haible wrote:
> Here's my counter-proposal (attached).
Thanks, that looks pretty good. I see three files that
still need work, though:
* lib/poll.c mentions "Win9x" and "WinXP".
* lib/select.c is similar.
* ChangeLog entries needed.
Also, the old-ChangeLog-entry work
On 01/03/2012 12:59 AM, Bruno Haible wrote:
>
> [A GOOD PROPOSAL]
>
Thanks for this carefully thought-out proposal. My only 2 cents of advice
is to report in the commit message of your patch the useful and extensive
arguments, explanations and references you have laid out so excellently in
your ma
On 01/03/2012 12:59 AM, Bruno Haible wrote:
Hi Paul,
Attached is a proposed Gnulib patch to fix some occurrences of
the "win" terminology problem.
It mostly just substitutes "Woe32" for "Win32", except that for
"Win32 API" it substitutes "Windows API".
It's good to clean up some of these ter
On 01/03/2012 12:59 AM, Bruno Haible wrote:
1) It contrasts with the NtDll API.[2] For example, file names passed
to NtDll functions can use a different syntax than file names
passed to Win32 functions.[3] This distinction matters because
programs build with gnulib should als
