Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-10-13 Thread Giuseppe Scrivano
Hello Jim, Jim Meyering writes: > Thanks again for the quick corrections. > Here's a better version. I'll wait for review this time ;-) I have tried the new version and it seems to work well. I am going to remove the workaround I had to use and keep my copy sync'ed with the gnulib version.

Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-10-13 Thread Jim Meyering
Jim Meyering wrote: > Giuseppe Scrivano wrote: > >> Hello, >> >> Jim Meyering writes: >> >>> Not sure about more "elegant", but here's a lower cost method: >> >> Thanks for the patch but I think the problem you have reported here: >> >> http://article.gmane.org/gmane.comp.lib.gnulib.bugs/21845

Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-10-13 Thread Jim Meyering
Giuseppe Scrivano wrote: > Hello, > > Jim Meyering writes: > >> Not sure about more "elegant", but here's a lower cost method: > > Thanks for the patch but I think the problem you have reported here: > > http://article.gmane.org/gmane.comp.lib.gnulib.bugs/21845 > > persists. > > > Here an examp

Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-10-13 Thread Giuseppe Scrivano
Hello, Jim Meyering writes: > Not sure about more "elegant", but here's a lower cost method: Thanks for the patch but I think the problem you have reported here: http://article.gmane.org/gmane.comp.lib.gnulib.bugs/21845 persists. Here an example, where /tmp/foo is a git repository. /tmp/

Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-10-13 Thread Jim Meyering
quot; > > I am not sure if there is a more "elegant" way to do it. Hi Giuseppe, Thanks for the suggestion. And thanks to Bruno for resurrecting this thread. > Subject: [PATCH] Do not limit git-version-gen to work only under the > repository root. > > * build-aux/

Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-05-10 Thread Giuseppe Scrivano
Sep 17 00:00:00 2001 From: Giuseppe Scrivano Date: Mon, 10 May 2010 10:58:01 +0200 Subject: [PATCH] Do not limit git-version-gen to work only under the repository root. * build-aux/git-version-gen: Modify check whether directory is controlled by git or not. --- ChangeLog |

Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-05-10 Thread Jim Meyering
ociated with the project at hand. > Subject: [PATCH] Do not limit git-version-gen to work only under the > repository root. > > * build-aux/git-version-gen: Check if it is a git repository using the > "git status" command instead of test'ing the .git directory presen

Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-05-10 Thread Bruno Haible
Hello Giuseppe, > +elif git describe > /dev/null 2>&1 \ If 'git' is not found in PATH, this line would yield an error message in some shells. To avoid that, run the command in a sub-shell: elif (git describe) > /dev/null 2>&1 \ > * build-aux/git-version-gen: Check if it is a git repository usi

[PATCH] Do not limit git-version-gen to work only under the repository root.

2010-05-10 Thread Giuseppe Scrivano
: Mon, 10 May 2010 10:58:01 +0200 Subject: [PATCH] Do not limit git-version-gen to work only under the repository root. * build-aux/git-version-gen: Check if it is a git repository using the "git status" command instead of test'ing the .git directory presence. --- ChangeLog