On Mon, May 4, 2009 at 3:26 AM, Bruno Haible wrote:
> It is pretty much clear that after removing all ACLs,
> 'func_test_has_acl tmpfile0 no' will work. The point of this test here is
> whether it's possible to remove the 'mask' part of the ACL only. If
> 'setfacl -x mask: tmpfile0' leads to an er
David Bartley wrote:
> I added a test case and made a few fixes for FreeBSD.
Thanks, mostly applied, as below. I beefed up the use of 'alarm' to look like
in the other gnulib unit tests.
The part I did not apply is this one:
# Remove the ACL for the mask, if it was implicitly added.
On Sun, May 3, 2009 at 6:33 PM, Bruno Haible wrote:
>
> Can you please also provide an augmented unit test that exhibits the bug?
> (Additional code in tests/test-file-has-acl* ?)
>
I added a test case and made a few fixes for FreeBSD. I successfully
ran the acl tests on Linux and FreeBSD (I don'
David Bartley wrote:
> The acl_get_entry related ones fix the loop logic;
> before the loop would infinitely loop (observable on freebsd via 'ls
> -ldv foo' where foo has a default acl set).
Thanks for reporting this.
Can you please also provide an augmented unit test that exhibits the bug?
(Addi
David Bartley wrote:
> The lib/set-mode-acl.c fix is benign, as sizeof(ace_t) == sizeof(aclent_t).
A bad bug nevertheless. Thank you. I applied this fix.
Bruno
lt acl set).
-- David
From 906d2bb2eb7ae6e5c055f63c44f82a24641d17f8 Mon Sep 17 00:00:00 2001
From: David Bartley
Date: Sun, 3 May 2009 18:34:06 -0400
Subject: [PATCH] Bug fixes in acl module.
* lib/acl_entries.c: Correctly check return of acl_get_entry.
* lib/file-has-acl.c: Likewise.
* lib/set-