Re: [PATCH]: pselect: new module

On 06/07/11 08:52, Paul Eggert wrote: >> No serial number here? > > I still don't get why hand-maintained serial numbers are useful > in m4/*.m4 files (and nowhere else?!). Maybe they were useful > long ago, but their cost outweighs their benefit now, as far as > I can see. I got this answer whe

Re: [PATCH]: pselect: new module

Thanks for your careful review, Bruno. I just now pushed some patches that I hope address most of your points, and will send out ten patch emails accordingly. The last one (patch 10/10) is the trickiest. I followed most of your advice, with the following quibbles. > If the emulation uses sigpro

Re: [PATCH]: pselect: new module

Paul, I wrote: > (which is probably why you didn't notice the missing > 'test $HAVE_PSELECT = 0'). This comment was not fair. There was no link error. I apologize. Bruno -- In memoriam Yonatan Netanyahu

Re: [PATCH]: pselect: new module

Hi Paul, More comments: > +++ b/m4/pselect.m4 > @@ -0,0 +1,31 @@ > +# pselect.m4 No serial number here? > + if test $ac_cv_func_pselect = no || test $gl_cv_sig_pselect = no; then > +REPLACE_PSELECT=1 > + fi > +#undef pselect > + > +int > +rpl_pselect (int nfds, fd_set *restrict rfds, T

Re: [PATCH]: pselect: new module

Hi Paul, > +/* Get definition of 'sigset_t'. > + But avoid namespace pollution on glibc systems. */ > +#if !(defined __GLIBC__ && !defined __UCLIBC__) > +# include > +#endif According to doc/posix-headers/signal.texi, it is not enough to include . You also need add a module dependency from 's

[PATCH]: pselect: new module

I pushed this; it's for Emacs, but I expect other applications can use nanosecond-resolution 'select' as well. No doubt there will be porting glitches. I've tested it on Solaris 8 (!) and Fedora 14 for starters. pselect: new module * lib/sys_select.in.h: Include , for 'sigset_t'. (pselect): New