The previous patch had an issue. Here is an updated version.
Ok, here is what I'm going to commit. I simplified a bit the logic to
not using ioctl on hosts other than Mac OS X.
The patch is -b to simplify reading it.
Thanks,
Paolo
2007-01-03 Paolo Bonzini <[EMAIL PROTECTED]>
Le vendredi 22 décembre 2006 à 12:41 +0100, Yoann Vandoorselaere a
écrit :
> Le vendredi 22 décembre 2006 à 11:55 +0100, Yoann Vandoorselaere a
> écrit :
> > Le vendredi 22 décembre 2006 à 11:31 +0100, Paolo Bonzini a écrit :
> > > >> and it does not work, e.g., on file descriptors. Sorry. :-)
>
Le vendredi 22 décembre 2006 à 11:55 +0100, Yoann Vandoorselaere a
écrit :
> Le vendredi 22 décembre 2006 à 11:31 +0100, Paolo Bonzini a écrit :
> > >> and it does not work, e.g., on file descriptors. Sorry. :-)
> > >
> > > Could you please provide more information about the problem? (Note that
Le vendredi 22 décembre 2006 à 11:31 +0100, Paolo Bonzini a écrit :
> >> and it does not work, e.g., on file descriptors. Sorry. :-)
> >
> > Could you please provide more information about the problem? (Note that
> > the current CVS version doesn't work on socket, which is not much
> > better).
and it does not work, e.g., on file descriptors. Sorry. :-)
Could you please provide more information about the problem? (Note that
the current CVS version doesn't work on socket, which is not much
better). Providing your test case would help.
Just open a file, and poll it. It should give
Le vendredi 22 décembre 2006 à 10:48 +0100, Paolo Bonzini a écrit :
> >>> I don't remember if it was Paul or Bruno who suggested that POLLHUP
> >>> does not increase the return value. What do you think?
> >
> > Attached is an improved version that should conform more to GnuLib
> > coding standard
I don't remember if it was Paul or Bruno who suggested that POLLHUP
does not increase the return value. What do you think?
Attached is an improved version that should conform more to GnuLib
coding standard.
Hi Yoann,
unfortunately the patch is wrong, as it never sets POLLHUP on Mac OS X
a
Yoann Vandoorselaere wrote:
Le mardi 19 décembre 2006 à 09:52 -0800, Paul Eggert a écrit :
Paolo Bonzini <[EMAIL PROTECTED]> writes:
I don't remember if it was Paul or Bruno who suggested that POLLHUP
does not increase the return value. What do you think?
It wasn't me, so I guess it was Brun
Le mardi 19 décembre 2006 à 09:52 -0800, Paul Eggert a écrit :
> Paolo Bonzini <[EMAIL PROTECTED]> writes:
>
> > I don't remember if it was Paul or Bruno who suggested that POLLHUP
> > does not increase the return value. What do you think?
>
> It wasn't me, so I guess it was Bruno. I don't have
Paolo Bonzini <[EMAIL PROTECTED]> writes:
> I don't remember if it was Paul or Bruno who suggested that POLLHUP
> does not increase the return value. What do you think?
It wasn't me, so I guess it was Bruno. I don't have any opinion on
this one, other than that if it seems good to you and Yoann
Le mardi 19 décembre 2006 à 09:38 +0100, Paolo Bonzini a écrit :
> > I have been experiencing several problem with the poll module,
> > especially under MacOS X.
>
> I was about to submit a patch for poll to fix some of these issues, but
> I prefer yours much more if it works. In fact, the FIONR
I have been experiencing several problem with the poll module,
especially under MacOS X.
I was about to submit a patch for poll to fix some of these issues, but
I prefer yours much more if it works. In fact, the FIONREAD ioctl is a
hack and my patch added yet another hack instead of using t
Hi,
I have been experiencing several problem with the poll module,
especially under MacOS X.
The module make the following assumption (quoting from the source): "An
hung up descriptor does not increase the return value".
- However, POSIX state:
Upon successful completion, poll() shall return
13 matches
Mail list logo
